Skip to content

[mono] Update runtimeFlavor property for Mono AOT perf jobs - #90215

Merged
kotlarmilos merged 1 commit into
dotnet:mainfrom
kotlarmilos:bugfix/perf-jobs-params
Aug 10, 2023
Merged

[mono] Update runtimeFlavor property for Mono AOT perf jobs#90215
kotlarmilos merged 1 commit into
dotnet:mainfrom
kotlarmilos:bugfix/perf-jobs-params

Conversation

@kotlarmilos

@kotlarmilos kotlarmilos commented Aug 9, 2023

Copy link
Copy Markdown
Member

This PR updates the runtimeFlavor property for Mono AOT performance jobs.

@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Aug 9, 2023
@kotlarmilos kotlarmilos self-assigned this Aug 9, 2023
@kotlarmilos
kotlarmilos requested a review from radical as a code owner August 9, 2023 09:18
@ghost

ghost commented Aug 9, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR sets the runtimeFlavor property for Mono AOT performance jobs.

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

area-Infrastructure-mono

Milestone: 8.0.0

@lewing

lewing commented Aug 9, 2023

Copy link
Copy Markdown
Member
[10:30:30] info: [2023-08-09T10:30:30.638Z] [FAIL] System.Net.WebSockets.Client.Tests.InvokerCloseTest.CloseOutputAsync_ClientInitiated_CanReceive_CanClose(server: ws://127.0.0.1:49166/WebSocket/EchoWebSocket.ashx)
[10:30:30] info: Assert.Equal() Failure
[10:30:30] info: Expected: 17
[10:30:30] info: Actual:   0
[10:30:30] info:    at System.Net.WebSockets.Client.Tests.CloseTest.CloseOutputAsync_ClientInitiated_CanReceive_CanClose(Uri server)
[10:30:30] info: --- End of stack trace from previous location ---
[10:30:30] info: [2023-08-09T10:30:30.639Z] [STRT] System.Net.WebSockets.Client.Tests.InvokerCloseTest.CloseOutputAsync_ClientInitiated_CanReceive_CanClose(server: wss://127.0.0.1:49168/WebSocket/EchoWebSocket.ashx)

@pavelsavara

Copy link
Copy Markdown
Member

InvokerCloseTest.CloseOutputAsync_ClientInitiated_CanReceive_CanClose

Could be just fragile test, let's re-run

@pavelsavara

Copy link
Copy Markdown
Member

I created #90257 to see if that happens more often

@kotlarmilos

Copy link
Copy Markdown
Member Author

The failure doesn't look related to the changes in this PR, could be a transient issue.

@kotlarmilos
kotlarmilos merged commit df5f3e6 into dotnet:main Aug 10, 2023
kotlarmilos added a commit that referenced this pull request Aug 14, 2023
LoopedBard3 pushed a commit that referenced this pull request Aug 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants