[wasm][debugger] Support calling get_Item passing decimal, float or double as parameter. - #90260
Merged
Conversation
|
Tagging subscribers to this area: @thaystg |
ilonatommy
approved these changes
Aug 10, 2023
| else if (expected == ElementType.R8) | ||
| Write(expected, objValue["value"].Value<double>()); | ||
| else | ||
| Write(expected, objValue["value"].Value<int>()); |
Member
There was a problem hiding this comment.
If we cast then we probably need all cases:
- ElementType.I2,
- ElementType.I4,
- ElementType.I8,
- ElementType.R4,
- ElementType.R8,
- ElementType.U2,
- ElementType.U4,
- ElementType.U8.
Or..let's test if adding tests with them won't throw here, maybe cast to int to all other cases is enough.
| ("f[shortString]", TBool(false)), | ||
| ("f[aFloat]", TNumber(1)), | ||
| ("f[aDouble]", TNumber(2)), | ||
| ("f[aDecimal]", TNumber(3)) // object |
Member
There was a problem hiding this comment.
Tests corresponding to the comment in MonoSDBHelper.
| return false; | ||
| break; | ||
| default: | ||
| return true; |
Member
There was a problem hiding this comment.
We're missing on this list:
- ElementType.U1,
- ElementType.Ptr,
- ElementType.I1,
- ElementType.ValueType,
- ElementType.Ptr,
- ElementType.Void,
radical
reviewed
Aug 10, 2023
|
|
||
| var signature = methodDef.Signature; | ||
| var sigReader = Assembly.asmMetadataReader.GetBlobReader(signature); | ||
| var decoder = new SignatureDecoder<ElementType, object>(_signatureTypeProvider, Assembly.asmMetadataReader, genericContext: null); |
Member
There was a problem hiding this comment.
genericContext: null - 👍 for adding the param name!
radical
reviewed
Aug 10, 2023
radical
changed the title
get_Item passing decimal, float or double as parameter.
radical
requested changes
Aug 10, 2023
| return false; | ||
| break; | ||
| case ElementType.Char: | ||
| if (parameterType != "string" && parameterType != "symbol") |
Member
There was a problem hiding this comment.
Does this also need a == "object" check?
| } | ||
| } | ||
|
|
||
| private static bool CheckParametersCompatibility(ElementType? typeCode, JObject value) |
| var parameterType = value["type"]?.Value<string>(); | ||
| var parameterClassName = value["className"]?.Value<string>(); | ||
|
|
||
| switch (typeCode.Value) |
Member
There was a problem hiding this comment.
Do IIUC that we are checking if value can be passed as an argument to a method with parameter type typeCode?
Comment on lines
+557
to
+559
| case ElementType.Object: | ||
| if (parameterType != "object") | ||
| return false; |
Member
There was a problem hiding this comment.
Do IIUC that we are checking if value can be passed as an argument to a method with parameter type typeCode?
If so, then shouldn't param type == object accept anything?
Member
Author
There was a problem hiding this comment.
If a method is expecting an object, can we call it passing a integer? I don't think so.
Comment on lines
+552
to
+553
| var parameterType = value["type"]?.Value<string>(); | ||
| var parameterClassName = value["className"]?.Value<string>(); |
Member
There was a problem hiding this comment.
Should these instead be argumentType, and argumentClassName?
ghost
added
the
needs-author-action
Co-authored-by: Ankit Jain <radical@gmail.com>
ghost
removed
the
needs-author-action
Member
Author
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
approved these changes
Aug 14, 2023
Member
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76014