Skip to content

Implement Edit and Continue on Linux and MacOS - #90349

Merged
mikelle-rogers merged 9 commits into
dotnet:mainfrom
mikelle-rogers:dev/mirogers/EnCCrossPlat
Aug 14, 2023
Merged

Implement Edit and Continue on Linux and MacOS#90349
mikelle-rogers merged 9 commits into
dotnet:mainfrom
mikelle-rogers:dev/mirogers/EnCCrossPlat

Conversation

@mikelle-rogers

@mikelle-rogers mikelle-rogers commented Aug 10, 2023

Copy link
Copy Markdown
Member

Fixes #12409

@ghost ghost added the area-VM-coreclr label Aug 10, 2023
@ghost ghost assigned mikelle-rogers Aug 10, 2023
jakobbotsch and others added 2 commits August 10, 2023 17:52
Fix build break

Fix arm build break
Fix arm build issue

Fix windows build break

Remove incorrect comment on exception interception
@mikelle-rogers
mikelle-rogers force-pushed the dev/mirogers/EnCCrossPlat branch from 5575896 to 91df810 Compare August 11, 2023 00:57
@mikelle-rogers
mikelle-rogers marked this pull request as ready for review August 11, 2023 16:57
Comment thread src/coreclr/vm/exceptionhandling.cpp Outdated
Comment thread src/coreclr/vm/exceptionhandling.cpp Outdated
Comment thread src/coreclr/vm/exceptionhandling.cpp Outdated
Comment thread src/coreclr/vm/eetwain.cpp Outdated
Comment thread src/coreclr/vm/eetwain.cpp Outdated

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/coreclr/vm/exceptionhandling.cpp Outdated
Comment thread src/coreclr/vm/exceptionhandling.cpp Outdated
Comment thread src/coreclr/vm/exceptionhandling.cpp Outdated
mikelle-rogers and others added 2 commits August 11, 2023 17:36
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@mikelle-rogers
mikelle-rogers merged commit e897946 into dotnet:main Aug 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit and Continue support in Linux

6 participants