[wasm] Respect AppendRuntimeIdentifierToOutputPath, and UseArtifactsOutput - #90365
Merged
Conversation
ghost
added
the
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details[wasm] Respect Also, remove all instances of
Fixes #89744 .
|
radical
force-pushed
the
wasm-use-artifacts-output
branch
from
August 11, 2023 08:34
3e908fb to
6ba33a5
Compare
radical
marked this pull request as draft
August 11, 2023 08:49
.. because we run tests in two modes: 1. with workloads - all the tests *without* `no-workload` category are run (thus the default) 2. no workloads - all the tests *with* `no-workload` category are run (thus need explicitly attributes)
.. `UseArtifactsOutput`. Fixes dotnet#89744 .
radical
force-pushed
the
wasm-use-artifacts-output
branch
from
August 13, 2023 03:22
6ba33a5 to
9f78e74
Compare
radical
marked this pull request as ready for review
August 13, 2023 03:23
ilonatommy
reviewed
Aug 14, 2023
ilonatommy
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, remove all instances of
ConditionalTheory IsUsingWorkloadsbecause we run tests in two modes:
no-workloadcategory arerun (thus the default)
no-workloadcategory are run(thus need explicitly attributes)
Fixes #89744 .