Fix ilasm casting - #90450
Merged
Merged
Conversation
Fix output to use `%zd` for size_t values.
ghost
assigned
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsFix a few cases where casting Fix some output functions to use Fix some error output to print the size of the "too long" string, not the truncated string.
|
Contributor
Author
|
/azp run runtime-coreclr ilasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@TIHan @dotnet/jit-contrib PTAL |
TIHan
approved these changes
Aug 14, 2023
TIHan
left a comment
TIHan
left a comment
Contributor
There was a problem hiding this comment.
Looks fine to me, straight-forward fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few cases where casting
strlencould truncate values.Fix some output functions to use
%zdforsize_ttypes.Fix some error output to print the size of the "too long" string, not the truncated string.