Skip to content

Fix illumos-x64 build - #90846

Merged
jkotas merged 3 commits into
dotnet:mainfrom
am11:feature/build/illumos-x64
Aug 19, 2023
Merged

Fix illumos-x64 build#90846
jkotas merged 3 commits into
dotnet:mainfrom
am11:feature/build/illumos-x64

Conversation

@am11

@am11 am11 commented Aug 19, 2023

Copy link
Copy Markdown
Member

Tested with:

$ docker run --rm -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x64 \
    mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-cross-illumos-20220531132048-f13d79e \
     /runtime/build.sh -c Release -os illumos -cross -gcc

$ echo $?
0

@ghost ghost added area-PAL-coreclr only for closed issues community-contribution Indicates that the PR has been added by a community member labels Aug 19, 2023
@am11
am11 marked this pull request as ready for review August 19, 2023 16:38
@am11

am11 commented Aug 19, 2023

Copy link
Copy Markdown
Member Author

cc @jkotas, @kunalspathak, fixed recent build regreession. __tls_get_addr needed @plt suffix (via EXTERNAL_C_FUNC) for solaris linker to look in linkage table (for relative address resolution) and __has_builtin definition missing in a few places, which I've moved to a common place in minipal.

Comment thread src/tests/profiler/native/profiler.h Outdated

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas
jkotas merged commit a9d74ac into dotnet:main Aug 19, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-PAL-coreclr only for closed issues community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants