Fix Item4 is missing in some ValueTuples' IStructuralEquatable.Equals#91461
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
|
@jeffhandley, we should backport this to release/8.0. |
It seems that it was introduced in net6.0 so do we need to backport it to 6.0 and 7.0 as well? |
|
With the potential for data loss that could occur in customers' applications, I do think we should backport this to 6.0 and 7.0 too. |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6052140869 |
|
/backport to release/7.0-staging |
|
/backport to release/6.0-staging |
|
Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/6052193377 |
|
Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/6052195472 |
|
@dotnet/compat -- Do you have any compatibility concerns with the 6.0 and 7.0 backports of this functional fix? It's clearly a behavioral change for the better, but could there be any surprises for customers when the patch goes through? |
|
Adding @marklio @PriyaPurkayastha for more comments. Is this fix merged into the latest .NET 8 RC2 build? We conducted a test pass with the latest build dotnet-sdk-8.0.100-rc.2.23456.6, and no related issues were found till now. |
Fixes #91457