Prevent restoring illink for native-binplace.proj#92289
Merged
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsFIxes #92194. The reference to illink from Fixed by explicitly marking this as not a source project, which will prevent the import of illink.targets. See the related discussion in #91233 (comment).
|
ViktorHofer
reviewed
Sep 19, 2023
ViktorHofer
approved these changes
Sep 19, 2023
jkoritzinsky
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIxes #92194. The reference to illink from
native-binplace.proj, built as a reference ofbuild-native.proj, was hitting a nuget bug with static graph restore. The bug seems to be specific to something about the project file (maybe the language-specific targets, sincenative-binplace.projimports theMicrosoft.NET.Sdk, but doesn't have acsprojextension).Fixed by explicitly marking this as not a source project, which will prevent the import of illink.targets. See the related discussion in #91233 (comment).