Skip to content

[LoongArch64] add LoongArch64's SIMD128/256 instructions within emitter.#95456

Merged
BruceForstall merged 2 commits into
dotnet:mainfrom
shushanhf:LA_SIMD_instrs
Dec 30, 2023
Merged

[LoongArch64] add LoongArch64's SIMD128/256 instructions within emitter.#95456
BruceForstall merged 2 commits into
dotnet:mainfrom
shushanhf:LA_SIMD_instrs

Conversation

@shushanhf
Copy link
Copy Markdown
Contributor

@shushanhf shushanhf commented Nov 30, 2023

This is the first PR to adding LoongArch64's SIMD128/256 within the JIT.

Add LoongArch64's SIMD128/256 instructions within emitter.

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Nov 30, 2023
@ghost
Copy link
Copy Markdown

ghost commented Nov 30, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This is the first PR to adding LoongArch64's SIMD128/256 within the JIT.

Add LoongArch64's SIMD128/256 instructions within emitter.

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@shushanhf
Copy link
Copy Markdown
Contributor Author

shushanhf commented Nov 30, 2023

Hi, @jakobbotsch
Could you please review this PR？
Thanks

@shushanhf shushanhf mentioned this pull request Dec 1, 2023
Closed
@shushanhf
Copy link
Copy Markdown
Contributor Author

shushanhf commented Dec 7, 2023

Hi, @jakobbotsch Could you please review this PR？ Thanks

Hi, @jakobbotsch
This PR is only the LoongArch64's ISA encoding, and independed of the API.

@jakobbotsch
Copy link
Copy Markdown
Member

jakobbotsch commented Dec 7, 2023

@shushanhf Thanks, I'll try to take a look soon, but it's a large PR and I need to set aside some time to do it. Hopefully I should be able to do that by the end of this week or at the beginning of the next one.

@shushanhf
Copy link
Copy Markdown
Contributor Author

shushanhf commented Dec 7, 2023

@shushanhf Thanks, I'll try to take a look soon, but it's a large PR and I need to set aside some time to do it. Hopefully I should be able to do that by the end of this week or at the beginning of the next one.

OK, Thanks!

@JulieLeeMSFT
Copy link
Copy Markdown
Member

JulieLeeMSFT commented Dec 15, 2023

CC @BruceForstall.

BruceForstall
BruceForstall reviewed Dec 21, 2023
View reviewed changes
Comment thread src/coreclr/jit/instrsloongarch64.h Outdated
Comment thread src/coreclr/jit/emitloongarch64.cpp Outdated
This was referenced Dec 22, 2023
Closed
Closed
BruceForstall
BruceForstall approved these changes Dec 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes. I hope the updated instruction dumper proves useful.

@BruceForstall BruceForstall merged commit 2de9fac into dotnet:main Dec 30, 2023
@shushanhf shushanhf deleted the LA_SIMD_instrs branch January 2, 2024 00:55
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@MichalPetryka MichalPetryka MichalPetryka left review comments

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstall BruceForstall

Labels

arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shushanhf @jakobbotsch @JulieLeeMSFT @BruceForstall @MichalPetryka