Skip to content

Fix JSON crashinfo exception object address #96284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikem8361 merged 2 commits into from
Dec 23, 2023
Merged

Fix JSON crashinfo exception object address #96284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce8a16b
Fix JSON crashinfo exception object address
Dec 22, 2023
b1a4c5a
Code review feedback
Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/coreclr/nativeaot/System.Private.CoreLib/src/System/CrashInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ private bool WriteExceptionHelper(ReadOnlySpan<byte> key, Exception exception, i
if (!OpenValue(key, '{'))
return false;

if (!WriteHexValue("address"u8, (ulong)Unsafe.AsPointer(ref exception)))
ulong address = Unsafe.As<Exception, nuint>(ref exception);
Copy link
Copy Markdown
Member

@MichalStrehovsky MichalStrehovsky Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the GC move the exception object between when we write this address in crashinfo and when the actual dump is generated?

Copy link
Copy Markdown
Member

@jkotas jkotas Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can. IIRC, it was discussed somewhere. It is not 100% reliable pattern.

The diagnostic stack likes to use it. Tracing uses in multiple places, e.g.

runtime/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/TplEventSource.cs

Line 505 in 9fa5128

public unsafe void RunningContinuation(int TaskID, object Object) { RunningContinuation(TaskID, (long)*((void**)Unsafe.AsPointer(ref Object))); }
.

if (!WriteHexValue("address"u8, address))
return false;

if (!WriteHexValue("hr"u8, exception.HResult))
Expand Down