Add ActiveIssue Annotations to Failing TestReadyToRun Tests and Reenable the Executables - #96721
Conversation
reenable their respective executables, so that the other tests in said run can be executed.
ivdiazsa
added
area-Infrastructure-libraries
disabled-test
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsCompletes #95928. This PR will introduce the necessary changes to enable as many libraries test executables as we can for the
|
ghost
assigned
|
I'm still in the process of filing the failing tests' issues. Will update the |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsCompletes #95928. This PR will introduce the necessary changes to enable as many libraries test executables as we can for the
|
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| [Fact] | ||
| [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix | ||
| // [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] |
There was a problem hiding this comment.
Wait why is this here? I'll check whether we need this or not. Working on it.
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
LGTM once you figure out what's up with the commented out ActiveIssue attribute.
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failure is unrelated, so merging this now. |
…ble the Executables (dotnet#96721) * Add "ActiveIssue" annotation placeholders to the failing tests, and reenable their respective executables, so that the other tests in said run can be executed. * Added "ActiveIssue" annotation to failing Threading test. * Added the ActiveIssue annotation to AppDomain.cs * Added the ActiveIssue template in FileSystemWatcher.File.Move.cs * Commented out an ActiveIssue annotation because I need to check on something in CI. * Reenabled another failing test because I need to see it in CI. * Yet another test being weird... * Disabled some Serialization tests after confirming in CI that they indeed not work. * Removed unneeded? commented out ActiveIssue annotation.
3 participants
Completes #95928. This PR will introduce the necessary changes to enable as many libraries test executables as we can for the
TestReadyToRunpipeline.