JIT ARM64-SVE: Add encodings FL_3A to FX_3A by amanasifkhalid · Pull Request #98832 · dotnet/runtime

amanasifkhalid · 2024-02-22T20:14:00Z

Part of #94549. Implements the following encodings:

IF_SVE_FL_3A
IF_SVE_FM_3A
IF_SVE_FN_3A
IF_SVE_FN_3B
IF_SVE_FO_3A
IF_SVE_FP_3A
IF_SVE_FQ_3A
IF_SVE_FS_3A
IF_SVE_FW_3A
IF_SVE_FX_3A

cstool output:

sabdlb        z0.h, z1.b, z2.b
sabdlt        z3.s, z4.h, z5.h
saddlb        z6.d, z7.s, z8.s
saddlt        z9.h, z10.b, z11.b
ssublb        z12.s, z13.h, z14.h
ssublt        z15.d, z16.s, z17.s
uabdlb        z18.h, z19.b, z20.b
uabdlt        z21.s, z22.h, z24.h
uaddlb        z24.d, z25.s, z26.s
uaddlt        z27.h, z28.b, z29.b
usublb        z30.s, z31.h, z0.h
usublt        z1.d, z2.s, z3.s
saddwb        z0.h, z1.h, z2.b
saddwt        z3.s, z4.s, z5.h
ssubwb        z6.d, z7.d, z8.s
ssubwt        z9.h, z10.h, z11.b
uaddwb        z12.s, z13.s, z14.h
uaddwt        z15.d, z16.d, z17.s
usubwb        z18.h, z19.h, z20.b
usubwt        z21.s, z22.s, z23.h
pmullb        z0.h, z1.b, z2.b
pmullt        z3.d, z4.s, z5.s
smullb        z6.h, z7.b, z8.b
smullt        z9.d, z10.s, z11.s
sqdmullb      z12.h, z13.b, z14.b
sqdmullt      z15.d, z16.s, z17.s
umullb        z18.h, z19.b, z20.b
umullt        z21.d, z22.s, z23.s
pmullb        z0.q, z1.d, z2.d
pmullt        z3.q, z4.d, z5.d
smmla z0.s, z1.b, z2.b
ummla z3.s, z4.b, z5.b
usmmla        z6.s, z7.b, z8.b
eorbt z0.b, z1.b, z2.b
eorbt z3.h, z4.h, z5.h
eortb z6.s, z7.s, z8.s
eortb z9.d, z10.d, z11.d
bdep  z0.b, z1.b, z2.b
bext  z3.h, z4.h, z5.h
bgrp  z6.s, z7.s, z8.s
bgrp  z9.d, z10.d, z11.d
saddlbt       z0.h, z1.b, z2.b
ssublbt       z3.s, z4.h, z5.h
ssubltb       z6.d, z7.s, z8.s
saba  z0.b, z1.b, z2.b
saba  z3.h, z4.h, z5.h
uaba  z6.s, z7.s, z8.s
uaba  z9.d, z10.d, z11.d
sabalb        z0.h, z1.b, z2.b
sabalt        z3.s, z4.h, z5.h
uabalb        z6.d, z7.s, z8.s
uabalt        z9.h, z10.b, z11.b

JitDisasm output:

sabdlb  z0.h, z1.b, z2.b
sabdlt  z3.s, z4.h, z5.h
saddlb  z6.d, z7.s, z8.s
saddlt  z9.h, z10.b, z11.b
ssublb  z12.s, z13.h, z14.h
ssublt  z15.d, z16.s, z17.s
uabdlb  z18.h, z19.b, z20.b
uabdlt  z21.s, z22.h, z24.h
uaddlb  z24.d, z25.s, z26.s
uaddlt  z27.h, z28.b, z29.b
usublb  z30.s, z31.h, z0.h
usublt  z1.d, z2.s, z3.s
saddwb  z0.h, z1.h, z2.b
saddwt  z3.s, z4.s, z5.h
ssubwb  z6.d, z7.d, z8.s
ssubwt  z9.h, z10.h, z11.b
uaddwb  z12.s, z13.s, z14.h
uaddwt  z15.d, z16.d, z17.s
usubwb  z18.h, z19.h, z20.b
usubwt  z21.s, z22.s, z23.h
pmullb  z0.h, z1.b, z2.b
pmullt  z3.d, z4.s, z5.s
smullb  z6.h, z7.b, z8.b
smullt  z9.d, z10.s, z11.s
sqdmullb z12.h, z13.b, z14.b
sqdmullt z15.d, z16.s, z17.s
umullb  z18.h, z19.b, z20.b
umullt  z21.d, z22.s, z23.s
pmullb  z0.q, z1.d, z2.d
pmullt  z3.q, z4.d, z5.d
smmla   z0.s, z1.b, z2.b
ummla   z3.s, z4.b, z5.b
usmmla  z6.s, z7.b, z8.b
eorbt   z0.b, z1.b, z2.b
eorbt   z3.h, z4.h, z5.h
eortb   z6.s, z7.s, z8.s
eortb   z9.d, z10.d, z11.d
bdep    z0.b, z1.b, z2.b
bext    z3.h, z4.h, z5.h
bgrp    z6.s, z7.s, z8.s
bgrp    z9.d, z10.d, z11.d
saddlbt z0.h, z1.b, z2.b
ssublbt z3.s, z4.h, z5.h
ssubltb z6.d, z7.s, z8.s
saba    z0.b, z1.b, z2.b
saba    z3.h, z4.h, z5.h
uaba    z6.s, z7.s, z8.s
uaba    z9.d, z10.d, z11.d
sabalb  z0.h, z1.b, z2.b
sabalt  z3.s, z4.h, z5.h
uabalb  z6.d, z7.s, z8.s
uabalt  z9.h, z10.b, z11.b

cc @dotnet/arm64-contrib

ghost · 2024-02-22T20:17:36Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of #94549. Implements the following encodings:

IF_SVE_FL_3A
IF_SVE_FM_3A
IF_SVE_FN_3A
IF_SVE_FN_3B
IF_SVE_FO_3A
IF_SVE_FP_3A
IF_SVE_FQ_3A
IF_SVE_FS_3A
IF_SVE_FW_3A
IF_SVE_FX_3A

cstool output:

sabdlb        z0.h, z1.b, z2.b
sabdlt        z3.s, z4.h, z5.h
saddlb        z6.d, z7.s, z8.s
saddlt        z9.h, z10.b, z11.b
ssublb        z12.s, z13.h, z14.h
ssublt        z15.d, z16.s, z17.s
uabdlb        z18.h, z19.b, z20.b
uabdlt        z21.s, z22.h, z24.h
uaddlb        z24.d, z25.s, z26.s
uaddlt        z27.h, z28.b, z29.b
usublb        z30.s, z31.h, z0.h
usublt        z1.d, z2.s, z3.s
saddwb        z0.h, z1.h, z2.b
saddwt        z3.s, z4.s, z5.h
ssubwb        z6.d, z7.d, z8.s
ssubwt        z9.h, z10.h, z11.b
uaddwb        z12.s, z13.s, z14.h
uaddwt        z15.d, z16.d, z17.s
usubwb        z18.h, z19.h, z20.b
usubwt        z21.s, z22.s, z23.h
pmullb        z0.h, z1.b, z2.b
pmullt        z3.d, z4.s, z5.s
smullb        z6.h, z7.b, z8.b
smullt        z9.d, z10.s, z11.s
sqdmullb      z12.h, z13.b, z14.b
sqdmullt      z15.d, z16.s, z17.s
umullb        z18.h, z19.b, z20.b
umullt        z21.d, z22.s, z23.s
pmullb        z0.q, z1.d, z2.d
pmullt        z3.q, z4.d, z5.d
smmla z0.s, z1.b, z2.b
ummla z3.s, z4.b, z5.b
usmmla        z6.s, z7.b, z8.b
eorbt z0.b, z1.b, z2.b
eorbt z3.h, z4.h, z5.h
eortb z6.s, z7.s, z8.s
eortb z9.d, z10.d, z11.d
bdep  z0.b, z1.b, z2.b
bext  z3.h, z4.h, z5.h
bgrp  z6.s, z7.s, z8.s
bgrp  z9.d, z10.d, z11.d
saddlbt       z0.h, z1.b, z2.b
ssublbt       z3.s, z4.h, z5.h
ssubltb       z6.d, z7.s, z8.s
saba  z0.b, z1.b, z2.b
saba  z3.h, z4.h, z5.h
uaba  z6.s, z7.s, z8.s
uaba  z9.d, z10.d, z11.d
sabalb        z0.h, z1.b, z2.b
sabalt        z3.s, z4.h, z5.h
uabalb        z6.d, z7.s, z8.s
uabalt        z9.h, z10.b, z11.b

JitDisasm output:

sabdlb  z0.h, z1.b, z2.b
sabdlt  z3.s, z4.h, z5.h
saddlb  z6.d, z7.s, z8.s
saddlt  z9.h, z10.b, z11.b
ssublb  z12.s, z13.h, z14.h
ssublt  z15.d, z16.s, z17.s
uabdlb  z18.h, z19.b, z20.b
uabdlt  z21.s, z22.h, z24.h
uaddlb  z24.d, z25.s, z26.s
uaddlt  z27.h, z28.b, z29.b
usublb  z30.s, z31.h, z0.h
usublt  z1.d, z2.s, z3.s
saddwb  z0.h, z1.h, z2.b
saddwt  z3.s, z4.s, z5.h
ssubwb  z6.d, z7.d, z8.s
ssubwt  z9.h, z10.h, z11.b
uaddwb  z12.s, z13.s, z14.h
uaddwt  z15.d, z16.d, z17.s
usubwb  z18.h, z19.h, z20.b
usubwt  z21.s, z22.s, z23.h
pmullb  z0.h, z1.b, z2.b
pmullt  z3.d, z4.s, z5.s
smullb  z6.h, z7.b, z8.b
smullt  z9.d, z10.s, z11.s
sqdmullb z12.h, z13.b, z14.b
sqdmullt z15.d, z16.s, z17.s
umullb  z18.h, z19.b, z20.b
umullt  z21.d, z22.s, z23.s
pmullb  z0.q, z1.d, z2.d
pmullt  z3.q, z4.d, z5.d
smmla   z0.s, z1.b, z2.b
ummla   z3.s, z4.b, z5.b
usmmla  z6.s, z7.b, z8.b
eorbt   z0.b, z1.b, z2.b
eorbt   z3.h, z4.h, z5.h
eortb   z6.s, z7.s, z8.s
eortb   z9.d, z10.d, z11.d
bdep    z0.b, z1.b, z2.b
bext    z3.h, z4.h, z5.h
bgrp    z6.s, z7.s, z8.s
bgrp    z9.d, z10.d, z11.d
saddlbt z0.h, z1.b, z2.b
ssublbt z3.s, z4.h, z5.h
ssubltb z6.d, z7.s, z8.s
saba    z0.b, z1.b, z2.b
saba    z3.h, z4.h, z5.h
uaba    z6.s, z7.s, z8.s
uaba    z9.d, z10.d, z11.d
sabalb  z0.h, z1.b, z2.b
sabalt  z3.s, z4.h, z5.h
uabalb  z6.d, z7.s, z8.s
uabalt  z9.h, z10.b, z11.b

cc @dotnet/arm64-contrib

Author:	amanasifkhalid
Assignees:	amanasifkhalid
Labels:	`area-CodeGen-coreclr`, `arch-arm64-sve`
Milestone:	-

ryujit-bot · 2024-02-22T22:35:32Z

Diff results for #98832

Assembly diffs

Assembly diffs for linux/arm64 ran on windows/x64

Diffs are based on 2,554,585 contexts (1,019,526 MinOpts, 1,535,059 FullOpts).

MISSED contexts: 172 (0.01%)

Overall (+0 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
libraries_tests.run.linux.arm64.Release.mch	381,315,748	+0	0.00%

FullOpts (+0 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
libraries_tests.run.linux.arm64.Release.mch	165,778,652	+0	0.00%

Assembly diffs for linux/x64 ran on windows/x64

Diffs are based on 2,543,224 contexts (988,245 MinOpts, 1,554,979 FullOpts).

MISSED contexts: 177 (0.01%)

Overall (-3 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
libraries_tests.run.linux.x64.Release.mch	329,922,608	-3	+0.16%

FullOpts (-3 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
libraries_tests.run.linux.x64.Release.mch	147,120,622	-3	+0.16%

Assembly diffs for osx/arm64 ran on windows/x64

Diffs are based on 2,317,543 contexts (945,402 MinOpts, 1,372,141 FullOpts).

MISSED contexts: 170 (0.01%)

Overall (+12 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
libraries_tests.run.osx.arm64.Release.mch	312,729,720	+12	+0.04%

FullOpts (+12 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
libraries_tests.run.osx.arm64.Release.mch	111,327,984	+12	+0.04%

Assembly diffs for windows/arm64 ran on windows/x64

Diffs are based on 2,402,908 contexts (955,693 MinOpts, 1,447,215 FullOpts).

MISSED contexts: 174 (0.01%)

Overall (+0 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
libraries_tests.run.windows.arm64.Release.mch	328,693,680	+0	0.00%

FullOpts (+0 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
libraries_tests.run.windows.arm64.Release.mch	123,601,008	+0	0.00%

Details here

Throughput diffs

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.osx.arm64.checked.mch	-0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	+0.01%

Details here

TIHan

LGTM, glad the formats have been straightforward.

amanasifkhalid · 2024-02-22T23:22:27Z

SPMI diffs look wrong for this PR? Those are the diffs I got for #98789; these changes shouldn't affect codegen at all.

Edit: This seems to be an issue on several PRs, so not related to this one.

TIHan · 2024-02-22T23:47:05Z

Yea, your changes shouldn't cause any diffs - so I think it's just a fluke.

amanasifkhalid added 11 commits February 21, 2024 10:11

Add FL_3A

f4d1b95

Add FM_3A

c219f88

wip

ef002aa

wip2

058c895

Add FN_3A, FN_3B

1815a05

Add FO_3A

4333779

Add FP_3A

60ab8b3

Add FQ_3A

1615307

Add FS_3A

a54b71d

Add FW_3A

5401fa3

Add FX_3A

7c41525

ghost assigned amanasifkhalid Feb 22, 2024

amanasifkhalid marked this pull request as ready for review February 22, 2024 20:17

amanasifkhalid added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support labels Feb 22, 2024

amanasifkhalid mentioned this pull request Feb 22, 2024

Arm64: Implement SVE encodings #94549

Closed

TIHan approved these changes Feb 22, 2024

View reviewed changes

amanasifkhalid merged commit 9512aab into dotnet:main Feb 23, 2024

amanasifkhalid deleted the sve-fl-3a branch February 23, 2024 01:05

github-actions Bot locked and limited conversation to collaborators Mar 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JIT ARM64-SVE: Add encodings FL_3A to FX_3A#98832

JIT ARM64-SVE: Add encodings FL_3A to FX_3A#98832
amanasifkhalid merged 11 commits into
dotnet:mainfrom
amanasifkhalid:sve-fl-3a

amanasifkhalid commented Feb 22, 2024 •

edited

Loading

Uh oh!

ghost commented Feb 22, 2024

Uh oh!

ryujit-bot commented Feb 22, 2024

Assembly diffs

Assembly diffs for linux/arm64 ran on windows/x64

Assembly diffs for linux/x64 ran on windows/x64

Assembly diffs for osx/arm64 ran on windows/x64

Assembly diffs for windows/arm64 ran on windows/x64

Throughput diffs

Throughput diffs for osx/arm64 ran on windows/x64

Throughput diffs for windows/arm64 ran on windows/x64

Uh oh!

TIHan left a comment

Uh oh!

amanasifkhalid commented Feb 22, 2024 •

edited

Loading

Uh oh!

TIHan commented Feb 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

amanasifkhalid commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Feb 22, 2024

Uh oh!

ryujit-bot commented Feb 22, 2024

Assembly diffs

Assembly diffs for linux/arm64 ran on windows/x64

Assembly diffs for linux/x64 ran on windows/x64

Assembly diffs for osx/arm64 ran on windows/x64

Assembly diffs for windows/arm64 ran on windows/x64

Throughput diffs

Throughput diffs for osx/arm64 ran on windows/x64

Throughput diffs for windows/arm64 ran on windows/x64

Uh oh!

TIHan left a comment

Choose a reason for hiding this comment

Uh oh!

amanasifkhalid commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TIHan commented Feb 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amanasifkhalid commented Feb 22, 2024 •

edited

Loading

amanasifkhalid commented Feb 22, 2024 •

edited

Loading