Skip to content

Fix CoreCLR stress pipelines that run libraries tests only#99868

Merged
jkoritzinsky merged 3 commits into
mainfrom
coreclr-libraries-outerloop-fix
Mar 18, 2024
Merged

Fix CoreCLR stress pipelines that run libraries tests only#99868
jkoritzinsky merged 3 commits into
mainfrom
coreclr-libraries-outerloop-fix

Conversation

@jkoritzinsky
Copy link
Copy Markdown
Member

Fixes failures in runtime-coreclr libraries-* pipelines

@ghost ghost added the area-Infrastructure-coreclr Only use for closed issues label Mar 16, 2024
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

jkoritzinsky

This comment was marked as outdated.

@jkoritzinsky
Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Mar 16, 2024

I have seen "You must specify at least one target queue to send a job to helix. Use the HelixTargetQueues property or HelixTargetQueue items." error in some jobs, e.g. https://github.com/dotnet/runtime/pull/98858/checks?check_run_id=22732088742

Is this related?

@jkoritzinsky
Copy link
Copy Markdown
Member Author

Looking at the error, that looks like more of a problem with specifying helix target queues. That would be more indicitive of a missing helixQueuesTemplate: argument to the platform-matrix template than the issue that this PR is fixing.

Copy link
Copy Markdown
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkoritzinsky
Copy link
Copy Markdown
Member Author

Fixed the extra-platforms as well

@jkoritzinsky
Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr libraries-jitstress, runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@BruceForstall
Copy link
Copy Markdown
Contributor

@jkoritzinsky Looks like there's still a problem with the Helix correlation payload:

C:\h\w\9782089C\w\97C508A0\e>"C:\h\w\9782089C\p\dotnet.exe" exec --runtimeconfig Common.Tests.runtimeconfig.json --depsfile Common.Tests.deps.json xunit.console.dll Common.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
'"C:\h\w\9782089C\p\dotnet.exe"' is not recognized as an internal or external command,
operable program or batch file.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=605856&view=results

(Not sure why the jobs aren't showing up in the "Checks" list above)

…nfiguration as the job config when running libraries tests
@jkoritzinsky
Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr outerloop,runtime-coreclr libraries-jitstress, runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jkoritzinsky jkoritzinsky merged commit a2f99a4 into main Mar 18, 2024
@jkoritzinsky jkoritzinsky deleted the coreclr-libraries-outerloop-fix branch March 18, 2024 14:34
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclr Only use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants