Update ILLink - #12420
Merged
Merged
Conversation
Member
|
Any chance this build includes dotnet/linker#1344? We need that to enable some attribute removal in the runtime. |
eerhardt
reviewed
Jul 10, 2020
| DefaultAction="$(TrimMode)" | ||
| LinkSymbols="$(_TrimmerLinkSymbols)" | ||
| TrimMode="$(TrimMode)" | ||
| RemoveSymbols="$(TrimmerRemoveSymbols)" |
Member
There was a problem hiding this comment.
FYI - @joperezr - our runtime tests are going to fail when we uptake this change.
Member
There was a problem hiding this comment.
Thanks for the headsup, I'm also expecing one more thing to break our tests which is the TrimMode rename. I'll keep an eye on darc update PRs and fix when we get the update.
Member
Author
|
Yup, the update includes dotnet/linker#1344. |
eerhardt
approved these changes
Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a manual dependency update to pick up a recent linker which has renamed some options.