[preview5] Remove linker warnings for native host and COM - #17699
Merged
sbomer merged 3 commits intoMay 19, 2021
Conversation
- Validation should look for all ILLink warnings (not all of them have the "ILLink :" text) - Don't collapse warnings in these tests to get more useful test output when they fail - Don't look for specific warning codes when there should be none
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
sbomer
changed the title
LakshanF
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes @LakshanF 's changes from #17657, except for the renamed properties, so that the feature switches get set using the existing names. This gets rid of the following warnings which were not caught by the test infra:
The warning checks in the tests have been made more strict. The issue was that the collapsed warnings weren't caught by the "ILLink :" check (they look like this):
To fix this I'm checking for "warning IL" instead, and also not collapsing the warnings for the baseline test cases to produce detailed warnings if the test fails.