Include the generated COM wrappers during the publish step - #4038
Merged
nguerrera merged 1 commit intoDec 12, 2019
Merged
Conversation
jkoritzinsky
approved these changes
Dec 10, 2019
nguerrera
approved these changes
Dec 10, 2019
Contributor
|
@livarcocc @wli3 3.1.2xx branch is open, right? |
rainersigwald
approved these changes
Dec 10, 2019
swaroop-sridhar
approved these changes
Dec 10, 2019
Member
Author
|
@nguerrera or @rainersigwald I don't think these test failures are mine. Do I need to do something about them? |
Member
Author
|
/azp run dotnet-sdk-public-ci |
|
Commenter does not have sufficient privileges for PR 4038 in repo dotnet/sdk |
Contributor
Member
Author
|
@nguerrera or @wli3 Yay! Any chance this can be merged in now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://developercommunity.visualstudio.com/content/problem/848273/publish-in-vs2019-do-not-process-com-assemblies.html
Fixes: dotnet/runtime#707
Fixes: #3993
/cc @rainersigwald @nguerrera @jkoritzinsky