Skip to content

Revert back to 3.1.0 runtime versions - #4040

Merged
wli3 merged 1 commit into
dotnet:release/3.1.2xxfrom
mmitche:revert-to-310-runtime
Dec 13, 2019
Merged

Revert back to 3.1.0 runtime versions#4040
wli3 merged 1 commit into
dotnet:release/3.1.2xxfrom
mmitche:revert-to-310-runtime

Conversation

@mmitche

@mmitche mmitche commented Dec 11, 2019

Copy link
Copy Markdown
Member

No description provided.

@mmitche
mmitche requested a review from wli3 December 11, 2019 02:05
@mmitche

mmitche commented Dec 11, 2019

Copy link
Copy Markdown
Member Author

These should start passing once new cli's and toolsets built on the older runtime propagate.

@mmitche

mmitche commented Dec 11, 2019

Copy link
Copy Markdown
Member Author

@wli3 These look like real errors here and need reaction.

@wli3

wli3 commented Dec 11, 2019

Copy link
Copy Markdown

@swaroop-sridhar could you look in the this test failure? I don't know the goal of the test. Seems a simple rename could resolve it

Failure from this file https://github.com/dotnet/sdk/blob/aacf12466528c876667088ce960e00bae6cbb75b/src/Assets/TestProjects/HelloWorldWithSubDirs/Program.cs

##[error].dotnet/sdk/3.1.200-preview-014770/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(198,5): error NU5119: (NETCORE_ENGINEERING_TELEMETRY=Build) File '/datadisks/disk1/workspace/_work/9/s/artifacts/bin/Tests/Microsoft.NET.Publish.Tests/Debug/publish/Assets/TestProjects/HelloWorldWithSubDirs/SmallNameDir/This is a directory with a really long name for one that only contains a small file/.word' was not added to the package. Files and folders starting with '.' or ending with '.nupkg' are excluded by default. To include this file, use -NoDefaultExcludes from the commandline

@swaroop-sridhar

Copy link
Copy Markdown
Contributor

Sure @wli3, I'll fix it.

@swaroop-sridhar

Copy link
Copy Markdown
Contributor

Here it is @wli3: #4044

@wli3

wli3 commented Dec 11, 2019

Copy link
Copy Markdown

@swaroop-sridhar thanks!

@wli3 wli3 added auto-merge Automatically merge PR once CI passes. Auto-Merge If Tests Pass labels Dec 12, 2019
@wli3
wli3 merged commit 05e157f into dotnet:release/3.1.2xx Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Merge If Tests Pass auto-merge Automatically merge PR once CI passes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants