Flow TargetArchitecture and TargetOS to inner repos - #48024
Merged
Conversation
Fixes dotnet/source-build#4313 Now especially necessary as the RID specific publishing mode depends on TargetArchitecture being available in the inner repo build.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (6)
- src/SourceBuild/content/repo-projects/Directory.Build.props: Language not supported
- src/SourceBuild/content/repo-projects/Directory.Build.targets: Language not supported
- src/SourceBuild/content/repo-projects/emsdk.proj: Language not supported
- src/SourceBuild/content/repo-projects/runtime.proj: Language not supported
- src/SourceBuild/content/repo-projects/sdk.proj: Language not supported
- src/SourceBuild/content/repo-projects/windowsdesktop.proj: Language not supported
ghost
added
Member
Author
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
reviewed
Mar 31, 2025
akoeplinger
approved these changes
Mar 31, 2025
wtgodbe
approved these changes
Mar 31, 2025
Member
Author
|
The failures are all expected. The "dotnet-sdk-public-ci" ones are due to repo specific issues that aren't impacted by this PR. Same for the "Final Join Build Pass" job which runs into disk space issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4313
Now especially necessary as the RID specific publishing mode depends on TargetArchitecture being available in the inner repo build: https://github.com/dotnet/arcade/blob/700bde8a8f6b0cfba19d1429684d6bdcaf3e1930/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L116-L122