Fix ExitCode build break - #55378
Closed
dsplaisted wants to merge 1 commit into
Closed
Conversation
This seems to have been introduced with a combination of #55362 and another PR
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a build break in dotnet.Tests caused by an ExitCode type-name collision between the CLI test command’s Microsoft.DotNet.Cli.Commands.Test.ExitCode and the SDK test framework’s Microsoft.NET.TestFramework.ExitCode brought into scope via test-wide global usings.
Changes:
- Adds a
usingalias to forceExitCodereferences inTerminalTestReporterTeststo bind toMicrosoft.DotNet.Cli.Commands.Test.ExitCode. - Documents the reason for the alias (global using collision originating from
test/Directory.Build.targets).
Member
Author
|
Superseded by #55372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to have been introduced with a combination of #55362 and another PR