Dont strip native debug symbols during build#272
Merged
Conversation
This patch makes coreclr and core-setup leave debug symbols in their built native code instead of stripping it out. After this patch, native symbols are only missing in corefx. A separate PR in corefx will take care of that: dotnet/corefx#24979 The final dotnet product, after both these fixes, should contain native debug symbols for all native binaries.
Member
Author
|
cc @dotnet/source-build-contrib |
eerhardt
approved these changes
Nov 2, 2017
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
I'm surprised that corefx didn't have this.
dagood
approved these changes
Nov 3, 2017
weshaggard
approved these changes
Nov 3, 2017
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
LGTM
I do wonder if we should potentially make this conditional in some way. Do we expect any cases where we want to strip the symbols.
Member
The only case I can think of is the long-term desire to use source-build to drive the Microsoft product build, where we provide the symbols separately in a symbol server. In that case, yeah, we should add a repo API parameter for native symbol stripping. I think it can wait until we get closer to needing it, though. |
Member
|
LGTM. Thanks @omajid ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes coreclr and core-setup leave debug symbols in their built native code instead of stripping it out.
After this patch, native symbols are only missing in corefx. A separate PR in corefx will take care of that: dotnet/corefx#24979. But this fix for core-setup and coreclr is independent and doesnt need that PR to work.
The final dotnet product, after both these fixes, should contain native debug symbols for all native binaries.
I used this to verify the final built product: https://gist.github.com/omajid/766aef59857de9fc1eab173119143abc
Resolves #267