Support HostApplicationBuildersSettings for framework application (#665) - #667
Merged
twsouthwick merged 6 commits intoFeb 26, 2026
Merged
Conversation
Contributor
Author
|
@dotnet-policy-service agree company="MOHELA" |
twsouthwick
requested changes
Feb 23, 2026
twsouthwick
left a comment
twsouthwick
left a comment
Member
There was a problem hiding this comment.
Overall looks good. A few comments mostly about keeping the change scoped to the issue at hand
EmperorArthur
force-pushed
the
HostApplicationBuilderSettings
branch
2 times, most recently
from
February 24, 2026 22:17
38eaa43 to
ef27592
Compare
Contributor
Author
|
Changes made, and scope limited. Appreciate the feedback. Sometimes it's easy to get lost in the weeds and go too far. Edit: We can have the conversation once you're happy with this. Don't want to let a broader discussion distract from fixing a real bug. |
…tnet#665) This updates HttpApplicationHost.CreateBuilder to more closely match HostApplicationBuilder's constructor. Supports setting any HostDefaults value via configuration or a HostApplicationBuildersSettings instance. This allows even more patterns used in modern ASP.NET Core applications to be available in ASP.NET Framework, including setting the application name and environment.
EmperorArthur
force-pushed
the
HostApplicationBuilderSettings
branch
from
February 24, 2026 22:27
ef27592 to
7a88f1e
Compare
twsouthwick
approved these changes
Feb 26, 2026
…osting/ConfigurationManagerConfigExtensions.cs
Member
|
great - this looks great. thanks for limiting the scope - feel free to start an issue to discuss the pattern for initializing the host |
twsouthwick
enabled auto-merge (squash)
February 26, 2026 18:08
twsouthwick
approved these changes
Feb 26, 2026
…osting/HttpApplicationHost.cs
twsouthwick
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates HttpApplicationHost.CreateBuilder to more closely match HostApplicationBuilder's constructor. Supports setting any HostDefaults value via configuration or a HostApplicationBuildersSettings instance. This allows even more patterns used in modern ASP.NET Core applications to be available in ASP.NET Framework, including setting the application name and environment.