Replace ArrayList with List in several designers#10432
Merged
Merged
Conversation
halgab
commented
Dec 5, 2023
| List<Control> tempList = new(); | ||
| tempList.AddRange(_dragControls); | ||
|
|
||
| DesignerUtils.CopyDragObjects(tempList, Component.Site); |
Contributor
Author
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| DesignerUtils.CopyDragObjects(tempList, Component.Site); | |
| tempList = DesignerUtils.CopyDragObjects(tempList, Component.Site); |
?
Member
There was a problem hiding this comment.
Hmm.. This does look a bit suspicious, but I am concerned about whether this was intentional and what effects this would have if we do make this change. It's not immediately clear from looking here. Let's open a separate issue on this to investigate.
Contributor
|
Might be overlap with #10279 |
Contributor
Author
|
@lonitra not sure what the CLA check has been up to for a week here... |
lonitra
approved these changes
Dec 14, 2023
| List<Control> tempList = new(); | ||
| tempList.AddRange(_dragControls); | ||
|
|
||
| DesignerUtils.CopyDragObjects(tempList, Component.Site); |
Member
There was a problem hiding this comment.
Hmm.. This does look a bit suspicious, but I am concerned about whether this was intentional and what effects this would have if we do make this change. It's not immediately clear from looking here. Let's open a separate issue on this to investigate.
Member
|
/azp run |
lonitra
added
the
ready-to-merge
|
Azure Pipelines successfully started running 2 pipeline(s). |
ghost
removed
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #8140
Proposed changes
ArrayListwithList<IComponent>inControlDesignerArrayListwithList<Control>inFlowLayoutPanelDesignerReplacesee Replace ArrayList with List in several designers #10432 (comment)ArrayListwithList<SnapLine>inFlowPanelDesignerArrayListwithList<IComponent>inTabControlDesignerMicrosoft Reviewers: Open in CodeFlow