Replace ArrayList usage in ToolStripItemDataObject with List

[halgab]

Contributes to #8140

Proposed changes

• Replace ArrayList usage in ToolStripItemDataObject with List
• Update relevant call sites to move off IList and ICollection interfaces

Microsoft Reviewers: Open in CodeFlow

[elachlan]

ToolStripItemBehavior.cs(656,119): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'components' does not exist in the current context

[halgab]

As mentioned here, this change might not be a no-brainer though...

[elachlan]

ToolStripMenuItemDesigner in the DemoConsole has had problems testing in the past see #9413

[elachlan]

@Olina-Zhang Is it possible for your team to test this? (I am not sure if it is, because demo console might not enable testing this)

I am concerned about the changes to ToolStripItemDataObject which is used "when a ToolStripItem is Drag-Dropped during DesignTime".

[halgab]

Abandoning this pr altogether is also a very acceptable outcome if we're not comfortable with it

[Olina-Zhang]

@elachlan @halgab We haven't started the test yet, should we run the test for this PR?

[halgab]

If you don't mind doing it, of course, please go ahead. Thanks a lot

[Olina-Zhang]

Tested this PR with some toolStripItems drag and drop scenarios in design time, no new issue found.

GH10626_testing.mp4

[elachlan]

Thanks @Olina-Zhang! We can definitely merge this then

[lonitra]

Thank you!

[MandiMan]

Tested this PR on .NET 9.0.0-preview.2.24076.2 with dlls built from winforms repo of main branch, no new issue found.

10626.mp4