Adds tests for AxSystemMonitor#10675
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10675 +/- ##
===================================================
+ Coverage 72.53589% 72.64503% +0.10914%
===================================================
Files 2900 2896 -4
Lines 622558 621803 -755
Branches 47003 46854 -149
===================================================
+ Hits 451578 451709 +131
+ Misses 162698 161793 -905
- Partials 8282 8301 +19
Flags with carried forward coverage won't be shown. Click here to find out more. |
lonitra
left a comment
There was a problem hiding this comment.
Were you able to add AxSystemMonitor in the AxHosts form designer and see it during runtime?
|
|
||
| namespace System.Windows.Forms.Tests; | ||
|
|
||
| public class AxSystemMonitorTests |
There was a problem hiding this comment.
Could you implement IDisposable so that the fields can be properly disposed similar to how ErrorProviderAccessibleObjectTests does so
There was a problem hiding this comment.
@JeremyKuhne was able to investigate #10692 and looks like the error you were running into while implementing IDisposable is an issue with only the AxSystemMonitor control. In order to implement IDisposable successfully, could you also add the following to the beginning of your implementation of Dispose():
using NoAssertContext context = new();
@lonitra,
After closing VS and rebuilding, I could run it: |
|
|
||
| namespace System.Windows.Forms.Tests; | ||
|
|
||
| public class AxSystemMonitorTests |
There was a problem hiding this comment.
@JeremyKuhne was able to investigate #10692 and looks like the error you were running into while implementing IDisposable is an issue with only the AxSystemMonitor control. In order to implement IDisposable successfully, could you also add the following to the beginning of your implementation of Dispose():
using NoAssertContext context = new();… line bellow itself.


Related #8302
Proposed changes
Customer Impact
Regression?
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow