Skip to content

Issue 8302 add tests for ax web browser#11137

Merged
ricardobossan merged 10 commits into
dotnet:mainfrom
ricardobossan:Issue_8302_Add_Tests_For_AxWebBrowser
Apr 3, 2024
Merged

Issue 8302 add tests for ax web browser#11137
ricardobossan merged 10 commits into
dotnet:mainfrom
ricardobossan:Issue_8302_Add_Tests_For_AxWebBrowser

Conversation

@ricardobossan
Copy link
Copy Markdown
Member

@ricardobossan ricardobossan commented Mar 28, 2024

Related to #8302

Proposed changes

  • Adds unit tests for the Microsoft Web Browser control.

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests

Test environment(s)

  • 9.0.100-preview.1.24101.2
Microsoft Reviewers: Open in CodeFlow

@ricardobossan ricardobossan self-assigned this Mar 28, 2024
@ricardobossan
Copy link
Copy Markdown
Member Author

Drafted this PR because most current tests need improvement, and new ones need to be added as well.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44347%. Comparing base (f0e4d81) to head (e948ef0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11137         +/-   ##
===================================================
+ Coverage   73.44338%   73.44347%   +0.00009%     
===================================================
  Files           3097        3098          +1     
  Lines         632155      632225         +70     
  Branches       46653       46653                 
===================================================
+ Hits          464276      464328         +52     
- Misses        164491      164499          +8     
- Partials        3388        3398         +10     
Flag Coverage Δ
Debug 73.44347% <100.00000%> (+0.00009%) ⬆️
integration 18.36087% <ø> (-0.00709%) ⬇️
production 46.90447% <ø> (-0.00635%) ⬇️
test 94.98599% <100.00000%> (+0.00101%) ⬆️
unit 43.85041% <ø> (-0.00072%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dotnet-policy-service dotnet-policy-service Bot added the draft draft PR label Mar 28, 2024
Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) added 2 commits March 28, 2024 07:29
Copy link
Copy Markdown
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But should we need to add some tests for the public function? @lonitra

@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Mar 29, 2024
@dotnet-policy-service dotnet-policy-service Bot removed the waiting-author-feedback The team requires more information from the author label Apr 2, 2024
@ricardobossan ricardobossan force-pushed the Issue_8302_Add_Tests_For_AxWebBrowser branch from b28c397 to 2615169 Compare April 2, 2024 00:55
@ricardobossan ricardobossan marked this pull request as ready for review April 2, 2024 00:56
@ricardobossan ricardobossan requested a review from a team as a code owner April 2, 2024 00:56
@dotnet-policy-service dotnet-policy-service Bot removed the draft draft PR label Apr 2, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Apr 2, 2024
Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) added 2 commits April 2, 2024 19:25
@dotnet-policy-service dotnet-policy-service Bot removed the waiting-author-feedback The team requires more information from the author label Apr 3, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Apr 3, 2024
@dotnet-policy-service dotnet-policy-service Bot removed the waiting-author-feedback The team requires more information from the author label Apr 3, 2024
Copy link
Copy Markdown
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Apr 3, 2024
@ricardobossan ricardobossan merged commit 3c3f911 into dotnet:main Apr 3, 2024
@dotnet-policy-service dotnet-policy-service Bot added this to the 9.0 Preview4 milestone Apr 3, 2024
@dotnet-policy-service dotnet-policy-service Bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Apr 3, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants