Skip to content

Fix issue 11954: [Dark Mode] ToolTip is not in dark mode after enabled SystemColorMode.Dark - #14381

Merged
SimonZhao888 merged 3 commits into
dotnet:mainfrom
SimonZhao888:Fix_issue_11954
Jul 1, 2026
Merged

Fix issue 11954: [Dark Mode] ToolTip is not in dark mode after enabled SystemColorMode.Dark#14381
SimonZhao888 merged 3 commits into
dotnet:mainfrom
SimonZhao888:Fix_issue_11954

Conversation

@SimonZhao888

@SimonZhao888 SimonZhao888 commented Mar 11, 2026

Copy link
Copy Markdown
Member

Fixes #11954

Proposed changes

  • Add dark mode support to Tooltip

Customer Impact

  • ToolTip is in dark mode after enabled SystemColorMode.Dark

Regression?

  • Yes

Risk

  • Min

Screenshots

Before

image

After

image

Test methodology

  • Manual

Test environment(s)

  • 11.0.0-alpha.1.25619.109
Microsoft Reviewers: Open in CodeFlow

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds dark mode theming for WinForms ToolTip windows when Application.SetColorMode(SystemColorMode.Dark) is enabled, aligning tooltip rendering with the rest of the app’s dark mode experience (issue #11954).

Changes:

  • Apply a dark-mode window theme to the tooltip HWND during handle creation when dark mode is enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/System.Windows.Forms/System/Windows/Forms/ToolTip/ToolTip.cs Outdated
Comment thread src/System.Windows.Forms/System/Windows/Forms/ToolTip/ToolTip.cs Outdated
@codecov

codecov Bot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.31573%. Comparing base (e98325a) to head (4c05296).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #14381         +/-   ##
===================================================
+ Coverage   77.31249%   77.31573%   +0.00324%     
===================================================
  Files           3265        3265                 
  Lines         644447      644451          +4     
  Branches       47631       47632          +1     
===================================================
+ Hits          498238      498262         +24     
+ Misses        142512      142499         -13     
+ Partials        3697        3690          -7     
Flag Coverage Δ
Debug 77.31573% <0.00000%> (+0.00324%) ⬆️
integration 19.13377% <0.00000%> (+0.00356%) ⬆️
production 52.28498% <0.00000%> (+0.00762%) ⬆️
test 97.41916% <ø> (ø)
unit 49.63699% <0.00000%> (+0.00452%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/System.Windows.Forms/System/Windows/Forms/ToolTip/ToolTip.cs Outdated
@SimonZhao888 SimonZhao888 added the waiting-review This item is waiting on review by one or more members of team label Apr 22, 2026

@KlausLoeffelmann KlausLoeffelmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!!

@LeafShi1 LeafShi1 added this to the 11.0-preview7 milestone Jul 1, 2026
@SimonZhao888
SimonZhao888 merged commit 3de8078 into dotnet:main Jul 1, 2026
8 checks passed
@SimonZhao888
SimonZhao888 deleted the Fix_issue_11954 branch July 1, 2026 03:08
@dotnet-policy-service dotnet-policy-service Bot removed the waiting-review This item is waiting on review by one or more members of team label Jul 1, 2026
@LeafShi1 LeafShi1 added the releasenotes-candidate This issue is a candidate to be mentioned in the release notes, if the respective PR fixed it. label Jul 15, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-DarkMode Issues relating to Dark Mode feature releasenotes-candidate This issue is a candidate to be mentioned in the release notes, if the respective PR fixed it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dark Mode] ToolTip is not in dark mode after enabled SystemColorMode.Dark

5 participants