Skip to content

[release/3.1] Update dependencies from dotnet/core-setup - #1762

Closed
dotnet-maestro[bot] wants to merge 2 commits into
release/3.1from
darc-release/3.1-b3c0e725-251e-4b0f-ad33-99bc5accc16a
Closed

[release/3.1] Update dependencies from dotnet/core-setup#1762
dotnet-maestro[bot] wants to merge 2 commits into
release/3.1from
darc-release/3.1-b3c0e725-251e-4b0f-ad33-99bc5accc16a

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/core-setup

  • Build: 20190904.16
  • Date Produced: 9/5/2019 1:23 AM
  • Commit: 93e1324ce55c1bbd01206eff6bd659bdf34f8fe1
  • Branch: refs/heads/release/3.1
  • Updates:
    • Microsoft.NETCore.App -> 3.1.0-preview1.19454.16

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Microsoft.NETCore.Platforms -> 3.0.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
  • Microsoft.Win32.Registry -> 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
  • Microsoft.Win32.SystemEvents -> 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
  • System.CodeDom -> 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
  • System.Configuration.ConfigurationManager -> 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
  • System.Drawing.Common -> 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
  • System.Resources.Extensions -> 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
  • System.Security.Cryptography.Cng -> 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
  • System.Security.Permissions -> 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
  • System.Windows.Extensions -> 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
  • Microsoft.NET.Sdk.IL -> 3.0.0-preview9.19409.2 (parent: Microsoft.NETCore.App)
  • Microsoft.NETCore.ILAsm -> 3.0.0-preview9.19409.2 (parent: Microsoft.NETCore.App)
Microsoft Reviewers: Open in CodeFlow

…0190904.13

- Microsoft.NETCore.App - 3.1.0-preview1.19454.13

Dependency coherency updates

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19454.6 (parent: Microsoft.NETCore.App)
- Microsoft.Win32.Registry - 4.7.0-rc1.19454.6 (parent: Microsoft.NETCore.App)
- Microsoft.Win32.SystemEvents - 4.7.0-rc1.19454.6 (parent: Microsoft.NETCore.App)
- System.CodeDom - 4.7.0-rc1.19454.6 (parent: Microsoft.NETCore.App)
- System.Configuration.ConfigurationManager - 4.7.0-rc1.19454.6 (parent: Microsoft.NETCore.App)
- System.Drawing.Common - 4.7.0-rc1.19454.6 (parent: Microsoft.NETCore.App)
- System.Resources.Extensions - 4.7.0-rc1.19454.6 (parent: Microsoft.NETCore.App)
- System.Security.Cryptography.Cng - 4.7.0-rc1.19454.6 (parent: Microsoft.NETCore.App)
- System.Security.Permissions - 4.7.0-rc1.19454.6 (parent: Microsoft.NETCore.App)
- System.Windows.Extensions - 4.7.0-rc1.19454.6 (parent: Microsoft.NETCore.App)
- Microsoft.NET.Sdk.IL - 3.0.0-preview9.19409.2 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.ILAsm - 3.0.0-preview9.19409.2 (parent: Microsoft.NETCore.App)
@dotnet-maestro
dotnet-maestro Bot requested a review from a team as a code owner September 4, 2019 23:29
@dotnet-maestro

dotnet-maestro Bot commented Sep 4, 2019

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI, dotnet-winforms CI (Build Windows Release), dotnet-winforms CI (Build Windows debug)

…0190904.16

- Microsoft.NETCore.App - 3.1.0-preview1.19454.16

Dependency coherency updates

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
- Microsoft.Win32.Registry - 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
- Microsoft.Win32.SystemEvents - 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
- System.CodeDom - 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
- System.Configuration.ConfigurationManager - 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
- System.Drawing.Common - 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
- System.Resources.Extensions - 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
- System.Security.Cryptography.Cng - 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
- System.Security.Permissions - 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
- System.Windows.Extensions - 4.7.0-rc1.19454.8 (parent: Microsoft.NETCore.App)
- Microsoft.NET.Sdk.IL - 3.0.0-preview9.19409.2 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.ILAsm - 3.0.0-preview9.19409.2 (parent: Microsoft.NETCore.App)
@zsd4yr

zsd4yr commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

@ericstj let's sync about what work needs to be done here. I think I remember you saying it was easy to temporarily fake something in Core-Setup to satisfy this

@dotnet-maestro

dotnet-maestro Bot commented Sep 5, 2019

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI, dotnet-winforms CI (Build Windows Release), dotnet-winforms CI (Build Windows debug)

@ericstj

ericstj commented Sep 5, 2019

Copy link
Copy Markdown
Member

Actually this look to be failing earlier than actually getting to the SDK:

dotnet-install: Downloading link: https://dotnetcli.azureedge.net/dotnet/Runtime/3.1.0-preview1.19454.16/dotnet-runtime-3.1.0-preview1.19454.16-win-x64.zip
dotnet-install: Cannot download: https://dotnetcli.azureedge.net/dotnet/Runtime/3.1.0-preview1.19454.16/dotnet-runtime-3.1.0-preview1.19454.16-win-x64.zip
dotnet-install: Downloading legacy link: https://dotnetcli.azureedge.net/dotnet/Runtime/3.1.0-preview1.19454.16/dotnet-win-x64.3.1.0-preview1.19454.16.zip
dotnet-install: Cannot download: https://dotnetcli.azureedge.net/dotnet/Runtime/3.1.0-preview1.19454.16/dotnet-win-x64.3.1.0-preview1.19454.16.zip

@dagood is 3.1 core-setup producing shared-framework zips correctly? /cc @mmitche

@dotnet-maestro

dotnet-maestro Bot commented Sep 5, 2019

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI, dotnet-winforms CI (Build Windows Release), dotnet-winforms CI (Build Windows debug)

@dagood

dagood commented Sep 5, 2019

Copy link
Copy Markdown
Member

A build with publish set up (dotnet/core-setup#7983 I think) probably hasn't finished yet. @mmitche is working on getting Core-Setup 3.1 going.

@dotnet-maestro

dotnet-maestro Bot commented Sep 5, 2019

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI, dotnet-winforms CI (Build Windows Release), dotnet-winforms CI (Build Windows debug)

@ericstj

ericstj commented Sep 5, 2019

Copy link
Copy Markdown
Member

I see, in that case if you wanted to make progress using this build you could remove this portion from the global.json:

winforms/global.json

Lines 9 to 11 in 9a69e1a

"dotnet": [
"$(MicrosoftNETCoreAppPackageVersion)"
]

That would let you get past this point of failure. You could put in other changes to have the SDK let you consume a the package out of core-setup, but you wouldn't be able to run tests.

Maybe its better to just wait for a more complete core-setup build. It's not really going to be a problem that WinForms/WPF are targeting older bits for some time.

@dotnet-maestro

dotnet-maestro Bot commented Sep 5, 2019

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI, dotnet-winforms CI (Build Windows Release), dotnet-winforms CI (Build Windows debug)

@RussKie RussKie closed this Sep 5, 2019
@RussKie
RussKie deleted the darc-release/3.1-b3c0e725-251e-4b0f-ad33-99bc5accc16a branch September 5, 2019 16:53
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants