Fix facade reference and unskip unit test#3098
Merged
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2413
Proposed changes
Add reference to System.Drawing facade in order to be able to unit-test it. If you don't do this you inherit the System.Drawing from shared framework
Microsoft.NetCore.Appwhich does not contain the same redirects as the WinForms version, in particular theUITypeEditorredirect is missing.Open questions
In the issue discussion it was noted that WinForms should not update the facade versions to 5.0 but instead keep them at 4.0 like the shared framework does.
The versioning problem does not prevent fixing the unit tests so it could be split off into a separate issue
The PR contains a workaround for deps.json for ProjectReferences is not emitted correctly sdk#3254 - will create a follow-up issue to track removal of the workaround unless something better can be figured out
Customer Impact
as is the PR has no customer impact
once we roll back the 5.0 versioning of System.Drawing and other facades this change is visible to users who already compiled against a 5.0 preview
Regression?
unclear, probably not (the regression part of not redirecting UITypeEditor should already have been fixed, we just couldn't test it)
Risk
low, as-is the PR only affects unit tests
once we roll back the 5.0 versioning of System.Drawing and other facades there may be some risk of breaking people who already have been compiling against earlier 5.0 previews and built nuget packages and stuff, but thats probably acceptable since its a preview?
Test methodology
skipped unit test now passes, test is now able to confirm what already was present in the product
Microsoft Reviewers: Open in CodeFlow