-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update inappropriate ComVisible attributes #3388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6870110
Remove ComVisible from enums
weltkante 373e4ff
Remove ComVisible from AccessibleObjects
weltkante a1a95f4
Remove COM attributes from Controls
weltkante ec7f222
Remove ComVisible from EventArgs
weltkante ac6e958
Remove ComVisible from non-public code
weltkante a81f761
Remove ComVisible from Delegates
weltkante 70daef2
Remove ComVisible from public classes
weltkante 6527a13
Resolve GUID conflict of IWin32Window
weltkante 60a8d3d
Remove ComVisible from IDataObject
weltkante 6082174
Remove redundant ComVisible
weltkante 0d1eaba
Make IWin32Window a managed interface
weltkante ed4bae4
Set default visibility for COM
weltkante cd5da9d
Fix WebBrowser scripting test
weltkante 537cd75
PR feedback: rename files
weltkante File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,8 +27,6 @@ namespace System.Windows.Forms | |
| /// list or to enter new text. Displays only the editing field until the user | ||
| /// explicitly displays the list. | ||
| /// </summary> | ||
| [ComVisible(true)] | ||
| [ClassInterface(ClassInterfaceType.AutoDispatch)] | ||
| [DefaultEvent(nameof(SelectedIndexChanged))] | ||
| [DefaultProperty(nameof(Items))] | ||
| [DefaultBindingProperty(nameof(Text))] | ||
|
|
@@ -3943,7 +3941,6 @@ protected override void WndProc(ref Message m) | |
| } | ||
| } | ||
|
|
||
| [ComVisible(true)] | ||
| private class ComboBoxChildNativeWindow : NativeWindow | ||
|
Comment on lines
3946
to
3944
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have no idea why this was ComVisible, probably was a mistake, most functionality which requires |
||
| { | ||
| private readonly ComboBox _owner; | ||
|
|
@@ -4535,7 +4532,6 @@ internal void SetItemInternal(int index, object value) | |
| } | ||
| } // end ObjectCollection | ||
|
|
||
| [ComVisible(true)] | ||
| public class ChildAccessibleObject : AccessibleObject | ||
| { | ||
| readonly ComboBox owner; | ||
|
|
@@ -4560,7 +4556,6 @@ public override string Name | |
| /// <summary> | ||
| /// Represents the ComboBox item accessible object. | ||
| /// </summary> | ||
| [ComVisible(true)] | ||
| internal class ComboBoxItemAccessibleObject : AccessibleObject | ||
| { | ||
| private readonly ComboBox _owningComboBox; | ||
|
|
@@ -4876,7 +4871,6 @@ public int GetId(object item) | |
| /// This inherits from the base ComboBoxExAccessibleObject and ComboBoxAccessibleObject | ||
| /// to have all base functionality. | ||
| /// </summary> | ||
| [ComVisible(true)] | ||
| internal class ComboBoxAccessibleObject : ControlAccessibleObject | ||
| { | ||
| private const int COMBOBOX_ACC_ITEM_INDEX = 1; | ||
|
|
@@ -5342,7 +5336,6 @@ internal override int[] RuntimeId | |
| /// <summary> | ||
| /// Represents the ComboBox's child (inner) list native window control accessible object with UI Automation provider functionality. | ||
| /// </summary> | ||
| [ComVisible(true)] | ||
| internal class ComboBoxChildListUiaProvider : ChildAccessibleObject | ||
| { | ||
| private const string COMBO_BOX_LIST_AUTOMATION_ID = "1000"; | ||
|
|
@@ -5584,7 +5577,6 @@ public override AccessibleStates State | |
| /// <summary> | ||
| /// Represents the ComboBox's child text (is used instead of inner Edit when style is DropDownList but not DropDown) accessible object. | ||
| /// </summary> | ||
| [ComVisible(true)] | ||
| internal class ComboBoxChildTextUiaProvider : AccessibleObject | ||
| { | ||
| private const int COMBOBOX_TEXT_ACC_ITEM_INDEX = 1; | ||
|
|
@@ -5759,7 +5751,6 @@ public override AccessibleStates State | |
| /// <summary> | ||
| /// Represents the ComboBox child (inner) DropDown button accessible object with UI Automation functionality. | ||
| /// </summary> | ||
| [ComVisible(true)] | ||
| internal class ComboBoxChildDropDownButtonUiaProvider : AccessibleObject | ||
| { | ||
| private const int COMBOBOX_DROPDOWN_BUTTON_ACC_ITEM_INDEX = 2; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.