Skip to content

Reduce allocations when tracing routed events #6700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rchauhan18 merged 3 commits into from
Sep 8, 2023
Merged

Reduce allocations when tracing routed events #6700

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28c5ede
Reduce allocations when tracing routed events.
bgrainger Jun 17, 2022
fa6bed0
Remove redundant code.
bgrainger Jun 17, 2022
54cc338
Use BooleanBoxes.
bgrainger Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 28 additions & 21 deletions src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/EventRoute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using SR=MS.Internal.PresentationCore.SR;
using SRID=MS.Internal.PresentationCore.SRID;
using MS.Internal;
using MS.Internal.KnownBoxes;

namespace System.Windows
{
Expand Down Expand Up @@ -193,27 +194,28 @@ private void InvokeHandlersImpl(object source, RoutedEventArgs args, bool reRais

// Invoke listeners

if( TraceRoutedEvent.IsEnabled )
var traceRoutedEventIsEnabled = TraceRoutedEvent.IsEnabled;
if ( traceRoutedEventIsEnabled )
{
_traceArguments ??= new object[3];
_traceArguments[0] = _routeItemList[i].Target;
_traceArguments[1] = args;
_traceArguments[2] = BooleanBoxes.Box(args.Handled);
TraceRoutedEvent.Trace(
TraceEventType.Start,
TraceRoutedEvent.InvokeHandlers,
_routeItemList[i].Target,
args,
args.Handled );

TraceRoutedEvent.InvokeHandlers,
_traceArguments);
}

_routeItemList[i].InvokeHandler(args);

if( TraceRoutedEvent.IsEnabled )
if( traceRoutedEventIsEnabled )
{
_traceArguments[2] = BooleanBoxes.Box(args.Handled);
TraceRoutedEvent.Trace(
TraceEventType.Stop,
TraceRoutedEvent.InvokeHandlers,
_routeItemList[i].Target,
args,
args.Handled );
TraceRoutedEvent.InvokeHandlers,
_traceArguments);
}


Expand Down Expand Up @@ -264,27 +266,29 @@ private void InvokeHandlersImpl(object source, RoutedEventArgs args, bool reRais
}


if( TraceRoutedEvent.IsEnabled )
var traceRoutedEventIsEnabled = TraceRoutedEvent.IsEnabled;
if ( traceRoutedEventIsEnabled )
{
_traceArguments ??= new object[3];
_traceArguments[0] = _routeItemList[i].Target;
_traceArguments[1] = args;
_traceArguments[2] = BooleanBoxes.Box(args.Handled);
TraceRoutedEvent.Trace(
TraceEventType.Start,
TraceRoutedEvent.InvokeHandlers,
_routeItemList[i].Target,
args,
args.Handled );
TraceRoutedEvent.InvokeHandlers,
_traceArguments);
}

// Invoke listeners
_routeItemList[i].InvokeHandler(args);

if( TraceRoutedEvent.IsEnabled )
if (traceRoutedEventIsEnabled)
{
_traceArguments[2] = BooleanBoxes.Box(args.Handled);
TraceRoutedEvent.Trace(
TraceEventType.Stop,
TraceRoutedEvent.InvokeHandlers,
_routeItemList[i].Target,
args,
args.Handled );
TraceRoutedEvent.InvokeHandlers,
_traceArguments);
}

}
Expand Down Expand Up @@ -552,6 +556,9 @@ internal void Clear()
// Stores Source Items for separated trees
private FrugalStructList<SourceItem> _sourceItemList;

// Stores arguments that are passed to TraceRoutedEvent.Trace (to reduce allocations)
private object[] _traceArguments;

#endregion Data
}
}
Expand Down