Skip to content

remove allocation in eventroute#9460

Closed
kasperk81 wants to merge 1 commit into
dotnet:mainfrom
kasperk81:patch-1
Closed

remove allocation in eventroute#9460
kasperk81 wants to merge 1 commit into
dotnet:mainfrom
kasperk81:patch-1

Conversation

@kasperk81
Copy link
Copy Markdown
Contributor

@kasperk81 kasperk81 commented Jul 25, 2024

#9467

Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service Bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Jul 25, 2024
@kasperk81 kasperk81 force-pushed the patch-1 branch 2 times, most recently from 5e39bf9 to 676d524 Compare July 25, 2024 10:53
@kasperk81 kasperk81 changed the title use collection expression in eventroute remove allocation in eventroute Jul 25, 2024
@kasperk81 kasperk81 force-pushed the patch-1 branch 2 times, most recently from 578b2e3 to 44aafc8 Compare July 25, 2024 11:24
@kasperk81
Copy link
Copy Markdown
Contributor Author

@GerardSmit applied your suggestion

@h3xds1nz
Copy link
Copy Markdown
Member

h3xds1nz commented Jul 25, 2024

Imho @lindexi solution would fix the immediate problem with releases in a more safe manner.

This whole thing with ROS<object> and stackallocs should be done in a more complex manner that fixes up the call chain from top to bottom with the additional allocations in the functions as you will miss plenty this way.

Do note also that you would want to use with C#13 params ReadOnlySpan<object> already. That way we would get rid of the additional overloads. I had this planned for later tbh eitherway.

@kasperk81
Copy link
Copy Markdown
Contributor Author

yea it require more refactoring

@kasperk81 kasperk81 closed this Jul 25, 2024
@kasperk81 kasperk81 deleted the patch-1 branch July 25, 2024 12:24
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Community Contribution A label for all community Contributions draft PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants