Replace occurrences of params T[] with params ReadOnlySpan<T> where possible#9481
Merged
Conversation
714abef to
1217ef8
Compare
Member
Author
|
I have fixed the merge conflict and rebased. |
1217ef8 to
10775f7
Compare
Member
Author
|
Resolved merge conflicts 09 |
dipeshmsft
reviewed
Oct 8, 2024
harshit7962
previously approved these changes
Jan 8, 2025
Member
harshit7962
left a comment
There was a problem hiding this comment.
The changes LGTM. @h3xds1nz, the changes can be taken in after resolving the conflicts.
…pan<InputGesture>
10775f7 to
c451e92
Compare
harshit7962
approved these changes
Jan 8, 2025
Member
harshit7962
left a comment
There was a problem hiding this comment.
Re-approving post conflict resolution.
Member
|
Thanks @h3xds1nz for the contribution. |
Member
Author
|
@harshit7962 Thanks, this one is big. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continues the journey that started in #9468 and converts some internal call-chains from
params T[]toparams ReadOnlySpan<T>where I felt it is without any side-effects, largely decreasing allocations in other scenarios besides just tracing and improving both performance and allocations since we do not need to create a new heap array ofT[]everytime.Simple benchmark with 0, 1, and 3 params
Benchmark code
Customer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build, test app run.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow