Fix unit tests native dependencies#9534
Merged
harshit7962 merged 1 commit intoSep 6, 2024
Merged
Conversation
dotnet-policy-service
Bot
added
PR
Merged
dipeshmsft
approved these changes
Aug 21, 2024
dipeshmsft
added
Queue for test pass
Included in test pass
and removed
Queue for test pass
labels
Member
|
@ThomasGoulet73 Thank you for your contribution. |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #8215
Description
Fixes unit tests native dependencies that were globbed too early which means that it skipped some dlls that were copied later in the build.
I also added comments for the code I previoulsy added to explain why it is needed.
Customer Impact
None, tests only.
Regression
No.
Testing
Local build + running unit tests.
Risk
None.
Microsoft Reviewers: Open in CodeFlow