Skip to content

Remove unnecessary MarshalLocal.IsTypeVisibleFromCom proxy for code quality#9609

Merged
dipeshmsft merged 1 commit into
dotnet:mainfrom
h3xds1nz:remove-marshal-local
Oct 8, 2024
Merged

Remove unnecessary MarshalLocal.IsTypeVisibleFromCom proxy for code quality#9609
dipeshmsft merged 1 commit into
dotnet:mainfrom
h3xds1nz:remove-marshal-local

Conversation

@h3xds1nz
Copy link
Copy Markdown
Member

@h3xds1nz h3xds1nz commented Aug 20, 2024

Description

Removes the MarshalLocal file/class with its proxy for IsTypeVisibleFromCom to increase code quality.

This has previously been added during initial WPF port efforts as .NET Core didn't have this functionality yet before 3.0, and later replaced back with the Marshal function by lindexi's #3279 after its addition, however there's no need for additional proxy class/method, it merely complicates the code for no benefit.

Customer Impact

Few bytes less in size of PresentationFramework.

Regression

No.

Testing

Local build.

Risk

None.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners August 20, 2024 20:41
@dotnet-policy-service dotnet-policy-service Bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Aug 20, 2024
@dipeshmsft
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants