Add test coverage for public API surface of MouseActionConverter#9891
Merged
Conversation
Member
Good point, this looks like an issue in the class implementation. |
dipeshmsft
reviewed
Jan 22, 2025
Member
dipeshmsft
left a comment
There was a problem hiding this comment.
Rest of the changes look good to me.
dipeshmsft
reviewed
Jan 22, 2025
c3d0283 to
085c76e
Compare
Member
Author
|
@dipeshmsft Added a bit more cases as well and converted to file-scoped as with all my newer tests (will do that bit for TextDecorations as well). It's rebased btw so I had to force push. |
dipeshmsft
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds test coverage for
MouseActionConverter. I've also fixed an unintentional behavioral change I've introduced with #9676, which would mean it wouldn't throwInvalidEnumArgumentExceptiondue to passing wrong value type to the exception.CanConvertTothrowsInvalidCastExceptiondue to an unboxing cast when you pass anintConvertTowhen you pass anintwithin rangeCustomer Impact
Improved test coverage on public surface.
Regression
Fixing my own oversight at the same time.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow