Remove double lookups on SizeLimitedCache<K, V>, improve performance#9949
Merged
Conversation
bb29d57 to
b2ff6b5
Compare
Member
Author
|
Rebased onto main. |
Contributor
|
@h3xds1nz: Just a ping to let you know that the test failures in this PR were fixed in main, pulling main should fix the failures. |
b2ff6b5 to
ebcfa79
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9949 +/- ##
===================================================
- Coverage 10.99508% 10.95662% -0.03847%
===================================================
Files 3215 3215
Lines 648472 648448 -24
Branches 71534 71530 -4
===================================================
- Hits 71300 71048 -252
- Misses 576170 576410 +240
+ Partials 1002 990 -12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
Thank you, @h3xds1nz, for your consistent and valuable contributions. Your hard work is greatly appreciated! 😄 |
Member
Author
|
@himgoyalmicro Thank you as always :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4828
Description
While checking out
SizeLimitedCache<K, V>yesterday, I've noticed the double lookups on the dictionary and today I've found there's already a corresponding issue for it, hence we should fix it for optimal performance as this is used with glyphs/fonts.ArgumentNullExceptiondirectly.Removehad even three lookups, so now it just has one.readonlyhave been adjusted.Nodeuses auto properties now.10 capacity, 15 unique additions first, 20 lookups
Customer Impact
Improved perfomance.
Regression
No.
Testing
Local build, tests with the class.
Risk
Low, just basically compiler warnings.
Microsoft Reviewers: Open in CodeFlow