feat: add ecs & phpstan code analysis#23
Open
khalwat wants to merge 3 commits into
Open
Conversation
97 Negated boolean expression is always false.
Contributor
Author
|
I did this only for the Craft 5 version of the plugin. If you want to backport it to Craft 4, it's the exact same everything for Craft 4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ecs&phpstancode analysisI also ran both
ecsandphpstan, which cleaned up the code, and I manually fixed one errorphpstanpointed out.You can manually run either
ecsorphpstanin local dev, and they will also automatically be run:v3-devbranchWhen someone does a PR, it'll look like this for them:
...and then once it has passed (or failed) it'll look like this: