Skip to content

feat: add ecs & phpstan code analysis#23

Open
khalwat wants to merge 3 commits into
doublesecretagency:v3-devfrom
khalwat:feature/add-ecs-phpstan
Open

feat: add ecs & phpstan code analysis#23
khalwat wants to merge 3 commits into
doublesecretagency:v3-devfrom
khalwat:feature/add-ecs-phpstan

Conversation

@khalwat
Copy link
Copy Markdown
Contributor

@khalwat khalwat commented Mar 12, 2024

Add ecs & phpstan code analysis

I also ran both ecs and phpstan, which cleaned up the code, and I manually fixed one error phpstan pointed out.

You can manually run either ecs or phpstan in local dev, and they will also automatically be run:

  • Whenever you push to the v3-dev branch
  • Whenever someone else does a PR

When someone does a PR, it'll look like this for them:

Screenshot 2024-03-11 at 10 30 55 PM

...and then once it has passed (or failed) it'll look like this:

Screenshot 2024-03-11 at 10 31 25 PM

@khalwat
Copy link
Copy Markdown
Contributor Author

khalwat commented Mar 12, 2024

I did this only for the Craft 5 version of the plugin. If you want to backport it to Craft 4, it's the exact same everything for Craft 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant