simple inline styles#7
Open
athanclark wants to merge 2 commits into
Open
Conversation
Author
|
After using the build in a private registry, I can confirm that this works as expected :) |
Contributor
|
Thanks for adding support for inline styles! I think that makes perfect sense. As for the height ideas, I am curious to know more what you are thinking about that. My instinct was that most people who would like this grid wouldn't be trying to control height that much (but it sounds like I may have missed the mark a bit). Also, I think we should add unit tests to make sure the styles get passed through, just to make sure future changes don't remove your work. Would you be willing to add the tests? or should I take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, I really like the feel this library gives me for designing grids, but I'd like more control over each generated element. I really like using inline styles for react components - it keeps the styling tightly coupled with the view, which I think is a good thing (for my use case at least). Would you be willing to give this freedom? If not, would you consider a height-based system? I'm not sure if you'd need to duplicate all of your width-based work in this other dimension (possibly squaring the work you need to do :P) or if we could simply hard-code some kind of fixed height. Either way, I think it would be useful.