[integration/peerlab] Bugfix/tiling issue - #42
Merged
Conversation
Tobiaspk
added a commit
that referenced
this pull request
May 26, 2026
Major: CUDA/Xenium install #21: CUDA 12.1 support; Xenium v1 + binary column datatype support; pixi/conda install updates Reference gene correlation #32: Add custom reference gene correlation support via `--gene-corr-reference-path` Memory optimisations #36: GPU/memory optimisations for large datasets; chunked subgraphing fallback Large dataset fixes #44: Fix torch array overflow and related scaling issues Tiling fixes #42: Fix tiling/bincount errors and transcript thresholding Minor: Logging improvements #31: Improve debug logging; support `SEGGER_LOG_LEVEL` Margin handling #34: Warn instead of fail when tiling margins are too large Misc cleanup: Refactors; assertions/debugging; remove unused code and comments --------- Co-authored-by: Nandula Co-authored-by: Kalfus
EliHei2
pushed a commit
that referenced
this pull request
Jun 1, 2026
Major: CUDA/Xenium install #21: CUDA 12.1 support; Xenium v1 + binary column datatype support; pixi/conda install updates Reference gene correlation #32: Add custom reference gene correlation support via `--gene-corr-reference-path` Memory optimisations #36: GPU/memory optimisations for large datasets; chunked subgraphing fallback Large dataset fixes #44: Fix torch array overflow and related scaling issues Tiling fixes #42: Fix tiling/bincount errors and transcript thresholding Minor: Logging improvements #31: Improve debug logging; support `SEGGER_LOG_LEVEL` Margin handling #34: Warn instead of fail when tiling margins are too large Misc cleanup: Refactors; assertions/debugging; remove unused code and comments --------- Co-authored-by: Nandula Co-authored-by: Kalfus
EliHei2
pushed a commit
that referenced
this pull request
Jun 1, 2026
[integration/peerlab] Bugfix/tiling issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40. This PR makes building QuadTree constructino more robust. This issue is common across datasets, but particularly often seen when processing the Atera Breast Cancer public dataset.
This PR fixes the error where
-1is passed intobincount.Cause:
cuspatialsometimes generates invalid QuadTrees where tiles overlap across levels, while other regions are not covered at all. This results in invalid tile assignments during spatial queries. This issue appears randomly despite the pipeline being deterministic, and occurs in roughly 2–35% of Segger runs. In some datasets, such as Atera, even 100%.Fix:
is_quadtree_valid: Simple validation that all points are covered by the generated quadtree.margin_boundstoget_quadtree_kwargs: Expands the bounds used to construct the quadtree. This produces more valid trees.max_size: If a generated tree is invalid, rebuild with an increased tree size. Particularly important for_points_in_polygons_containsinquery.py, which defaults tomax_size=10000. In the Atera dataset this frequently produces invalid trees.Example log of dynamically increasing tree size: