fix(tiling): fall back to a smaller margin instead of dropping tiles - #61
Merged
Conversation
When the inner-tile negative buffer uses too large a margin, small tiles shrink to empty. Previously those tiles were removed from the spatial query, silently dropping every geometry they contained (a frequent cause of large numbers of unassigned transcripts on dense/small-tile datasets). Instead, progressively halve the margin (down to 0) until every tile survives the buffer, emitting a warning with the reduced value. No behavior change when the requested margin already leaves all tiles non-empty. What to review: - src/segger/data/tiling.py: the buffer/fallback loop in the query method. - The loop is bounded (margin strictly halves; terminates at 0 = unbuffered tiles, which can never be empty), so it cannot spin. - Trade-off: a reduced margin means slightly less inner/outer separation for the affected tiles, which is strictly better than dropping their geometries.
Collaborator
|
I prefer this over the current approach to dropping empty tiles entirely. I'm good to move forward with this. But going forward, let's update this with a more dynamic approach that reduces empty tiles in the first place. @andrewmoorman suggested transcript-density-derived margins. Please also add your comments on this so we're on the same page. |
Collaborator
Author
|
I like transcript-density-derived margins, but that's another dev, for now for not entirely missing the tile could we put this in, then add that as a future TODO? |
Tobiaspk
approved these changes
Jun 9, 2026
Tobiaspk
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Let's make sure to update this in a future revision with a density based estimator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the inner-tile negative buffer uses too large a margin, small tiles shrink to empty. Previously those tiles were removed from the spatial query, silently dropping every geometry they contained (a frequent cause of large numbers of unassigned transcripts on dense/small-tile datasets).
Instead, progressively halve the margin (down to 0) until every tile survives the buffer, emitting a warning with the reduced value. No behavior change when the requested margin already leaves all tiles non-empty.
What to review: