Skip to content

Add 4 cities to Central department and fix Asuncion bug in Paraguay#1108

Merged
dr5hn merged 5 commits intodr5hn:masterfrom
edyhvh:fix/paraguay
Oct 9, 2025
Merged

Add 4 cities to Central department and fix Asuncion bug in Paraguay#1108
dr5hn merged 5 commits intodr5hn:masterfrom
edyhvh:fix/paraguay

Conversation

@edyhvh
Copy link
Contributor

@edyhvh edyhvh commented Oct 6, 2025

Fix Asunción State Categorization and Add Cities to Central Department (Paraguay)

Description

This PR addresses two issues in the Paraguay database:

  1. Asunción (capital) was incorrectly categorized as "capital" instead of "department", preventing it from appearing in the states list
  2. Missing cities in the Central department

Changes Made

New Cities Added to Central Department (Paraguay):

  • Julián Augusto Saldívar (ID: 157022, WikiData: Q2717412)
  • Luque (ID: 157023, WikiData: Q946497)
  • Villeta (ID: 157024, WikiData: Q1093439)
  • Ypané (ID: 157025, WikiData: Q2717436)

Bug Fix:

Technical Details:

  • Cities added in alphabetical order within the Central department
  • All WikiData IDs verified and correct
  • Coordinates obtained from reliable sources
  • Unique IDs incrementing from last used ID (157021)
  • Only sql/world.sql was modified as per CONTRIBUTING.md guidelines
  • JSON files will be regenerated automatically upon merge
  • Follows all database schema requirements

Files Changed

  • sql/world.sql: Added 4 new cities + Asunción fix

Fixes #1107

edyhvh added 2 commits October 6, 2025 20:22
- Add Julián Augusto Saldívar (ID: 157022, WikiData: Q2717412)
- Add Luque (ID: 157023, WikiData: Q946497)
- Add Villeta (ID: 157024, WikiData: Q1093439)
- Add Ypané (ID: 157025, WikiData: Q2717436)
- Cities added in alphabetical order within Central department (JSON)
- Fix Asunción state type from 'capital' to 'department' (fixes dr5hn#1107)
- Fix Ypacarai longitude coordinate
- All changes follow CONTRIBUTING.md guidelines
- Add Julián Augusto Saldívar (ID: 157022, WikiData: Q2717412)
- Add Luque (ID: 157023, WikiData: Q946497)
- Add Villeta (ID: 157024, WikiData: Q1093439)
- Add Ypané (ID: 157025, WikiData: Q2717436)
- Cities added in alphabetical order within Central department (JSON)
- Fix Asunción state type from 'capital' to 'department' (fixes dr5hn#1107)
- All changes follow CONTRIBUTING.md guidelines
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Oct 6, 2025
@dr5hn
Copy link
Owner

dr5hn commented Oct 7, 2025

@yonice7 Thanks for the PR!

I don’t see any file changes under the “Files changed” tab.

Please note that you only need to update the world.sql file — the other files will be generated automatically once your PR is approved and merged.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 7, 2025
@edyhvh
Copy link
Contributor Author

edyhvh commented Oct 7, 2025

@yonice7 Thanks for the PR!

I don’t see any file changes under the “Files changed” tab.

Please note that you only need to update the world.sql file — the other files will be generated automatically once your PR is approved and merged.

Hi @dr5hn just edited the world.sql file only, should be able to see the changes here lemme know if I’m missing anything else, thanks

@dr5hn
Copy link
Owner

dr5hn commented Oct 8, 2025

Screenshot 2025-10-08 at 12 43 39 PM

@yonice7 Thanks for the update!

There’s one more thing to adjust — the sequence of city additions. The new cities should be added at the end of the list, but right now they’re being inserted randomly among existing entries.

Please fix that and let me know once it’s done.

@edyhvh
Copy link
Contributor Author

edyhvh commented Oct 9, 2025

hi @dr5hn thanks for letting me know, I just added them to the end of the list

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 9, 2025
@dr5hn dr5hn merged commit e8e7a71 into dr5hn:master Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paraguay Missing Asunción State/Department

2 participants