Skip to content

Fix German state native names#1333

Open
Copilot wants to merge 5 commits intomasterfrom
copilot/update-german-translations
Open

Fix German state native names#1333
Copilot wants to merge 5 commits intomasterfrom
copilot/update-german-translations

Conversation

Copy link
Contributor

Copilot AI commented Jan 11, 2026

What changed?

Fixed incorrect native language names for 6 German states in the database.

German State Corrections:

  • Lower Saxony: "Niedrigere Sachsen" → "Niedersachsen"
  • North Rhine-Westphalia: "North Rhein-Westphalia" → "Nordrhein-Westfalen"
  • Rhineland-Palatinate: "Rheinland-Palatinat" → "Rheinland-Pfalz"
  • Saxony: "Saxony" → "Sachsen"
  • Saxony-Anhalt: "Saxony-Anhalt" → "Sachsen-Anhalt"
  • Mecklenburg-Vorpommern: "Mecklenburg-vorpommern" → "Mecklenburg-Vorpommern"

Type of Change

  • 🐛 Bug/Data fix
  • ✨ New data (cities/states/countries)
  • 📝 Data update
  • 🔧 Infrastructure/Scripts
  • 📚 Documentation

Affected Locations

  • Germany (6 states with corrected native names)

Checklist

  • Edited JSON files in contributions/ directory
  • Omitted id field for new records (auto-assigned)
  • Verified data against reliable sources
  • Tested locally (optional)

Sources

Notes

The name field uses English (international standard), while native and translations.de contain proper German names. This aligns with the repository's convention for consistent API behavior across all countries.

Export files (states.json, countries+states+cities.json) automatically updated via import/export cycle.

Original prompt

This section details on the original issue you should resolve

<issue_title>[Bug]: Data should get a update and Translation for German Data should be fixed</issue_title>
<issue_description>### Issue Type

Incorrect Data (wrong information)

Location (if applicable)

No response

What's wrong?

The file was not updated in a year and some translations are not correct (English and German is mixed in the states names)

Link: https://github.com/dr5hn/countries-states-cities-database/blob/2f33b1b1ddcdb426da9953371f25e7b162c8366d/json/states%2Bcities.json

What should it be?

Update of the file with newer data (sync with other files in the repo) and fix of the translations.

Source (optional)

No response</issue_description>

<agent_instructions>Check why this file is not being updated.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits January 11, 2026 07:22
Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
…ation

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
Copilot AI changed the title [WIP] Update data and fix German translations Fix states+cities.json export and correct German state native names Jan 11, 2026
Copilot AI requested a review from dr5hn January 11, 2026 07:33
@dr5hn
Copy link
Owner

dr5hn commented Jan 11, 2026

@copilot revert the last commit andd delete the file we are not exporting that file anymore

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 11, 2026

@copilot revert the last commit andd delete the file we are not exporting that file anymore

Reverted in commit b946e46. The states+cities.json export has been removed from ExportJson.php, the file reverted to its previous state, and the documentation deleted. The German state name corrections remain in place.

Copilot AI changed the title Fix states+cities.json export and correct German state native names Fix German state native names Jan 11, 2026
@dr5hn dr5hn marked this pull request as ready for review January 11, 2026 19:52
Copilot AI review requested due to automatic review settings January 11, 2026 19:52
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 11, 2026
@dosubot dosubot bot added lgtm This PR has been approved by a maintainer bug Something isn't working labels Jan 11, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Data should get a update and Translation for German Data should be fixed

3 participants