Skip to content

Allow building from tags#225

Merged
asmeurer merged 21 commits into
masterfrom
tag
Nov 20, 2017
Merged

Allow building from tags#225
asmeurer merged 21 commits into
masterfrom
tag

Conversation

@asmeurer

Copy link
Copy Markdown
Member

Adds --build-tags flag. How to use is described in the recipes in the docs.

Will need to push some tags to GitHub to test this.

Fixes #29.

Adds --build-tags flag.  How to use is described in the recipes in the docs.

Will need to push some tags to GitHub to test this.

Fixes #29.
@asmeurer

Copy link
Copy Markdown
Member Author

My thinking here is that we can use the same doctr deploy command for both tags and branch builds, with different deploy directories handled with logic outside of the command.

But now I'm wondering what's the cleanest way to deploy only from tags. There's no way to specify the branch whitelist from the command line.

@asmeurer

Copy link
Copy Markdown
Member Author

Small compatibility break with --branch-whitelist here. Needs to be documented in the release notes.

@asmeurer

Copy link
Copy Markdown
Member Author

OK, I think the code is ready, but we need to test it by pushing some tags. Probably need to merge first.

@asmeurer

Copy link
Copy Markdown
Member Author

Ended up being a little fragile. We should test this pretty hard once merging.

@CJ-Wright

Copy link
Copy Markdown
Contributor

Is this ready to merge?

@asmeurer

Copy link
Copy Markdown
Member Author

I think it needs some more testing. Maybe I should push some fake tags up for this branch to make sure it all works.

@asmeurer

asmeurer commented Sep 8, 2017

Copy link
Copy Markdown
Member Author

I think I might hold off on merging this until after the next release (1.6), since there are already a lot of changes and I want them to stabilize first.

@CJ-Wright

Copy link
Copy Markdown
Contributor

Has there been any progress on this? Is there something we can to do help?

@asmeurer

Copy link
Copy Markdown
Member Author

I haven't had the time to work on it. I'm pretty sure it's ready to go, but I just want to do some testing before I merge, as I remember the changes here being somewhat finicky.

@asmeurer

Copy link
Copy Markdown
Member Author

OK, it seems to work. I'm merging. Will try to get a release out some time this week (hopefully tomorrow).

@asmeurer asmeurer merged commit 6ad5dc6 into master Nov 20, 2017
@asmeurer asmeurer deleted the tag branch November 20, 2017 00:44
@CJ-Wright

Copy link
Copy Markdown
Contributor

WOOO thank you so very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants