Skip to content

Add and remove all the files in one git command#325

Merged
asmeurer merged 8 commits into
masterfrom
add-fix
Sep 19, 2018
Merged

Add and remove all the files in one git command#325
asmeurer merged 8 commits into
masterfrom
add-fix

Conversation

@asmeurer

Copy link
Copy Markdown
Member

This might fix #324.

@asmeurer

Copy link
Copy Markdown
Member Author

This ran pretty quick for me adding 10000 empty files.

See if my test in .travis.yml really does test the right thing.
@asmeurer

Copy link
Copy Markdown
Member Author

And I can confirm my test is slower the old way, even though they're empty files, by about a minute and a half. https://travis-ci.org/drdoctr/doctr/jobs/430365436.

@thequackdaddy can you try running your build against this branch (install doctr from this branch)?

@asmeurer

Copy link
Copy Markdown
Member Author

Or I can try it out myself tomorrow if you don't get to it.

@thequackdaddy

Copy link
Copy Markdown
Contributor

Nice. You shaved 25 minutes off the build!

https://travis-ci.org/thequackdaddy/statsmodels/jobs/430370425

@asmeurer

Copy link
Copy Markdown
Member Author

Awesome. We should still figure out how to only add the changed files to shorten the output size in the log, but I'll leave that for a future PR.

@asmeurer asmeurer merged commit 314fe1c into master Sep 19, 2018
@asmeurer asmeurer deleted the add-fix branch September 19, 2018 06:08
@thequackdaddy

Copy link
Copy Markdown
Contributor

Thanks for the fast turnaround on this.

Do you plan to release to pypi soon? Otherwise, I will make a PR on statsmodels to install from master here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doctr with lots of files in docs

2 participants