feat(sheets): add mutations and commands for addWorkbookStyles & removeWorkbookStyles#6230
Open
IMSupperkaka wants to merge 2 commits intodream-num:devfrom
Open
feat(sheets): add mutations and commands for addWorkbookStyles & removeWorkbookStyles#6230IMSupperkaka wants to merge 2 commits intodream-num:devfrom
IMSupperkaka wants to merge 2 commits intodream-num:devfrom
Conversation
View Deployment
|
Member
|
Could you describe the issue your PR is intended to solve? |
Contributor
Author
Because using cellData = {
v: 'sdad',
s: 'Yauoq-Xa'
}At this time, you need to execute the univer/packages/sheets/src/facade/f-workbook.ts Lines 1119 to 1121 in f595b78 univer/packages/sheets/src/facade/f-workbook.ts Lines 1161 to 1163 in f595b78 |
Member
|
LGTM, but this command doesn’t need to perform an undo/redo, only mutations do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…okStyles
close #xxx
Pull Request Checklist