Upgrading to the cljs r2665

[matevarga]

No description provided.

[factom]

Thanks for this! I don't understand the changes to the unit test though - let me look at this more tonight.

[matevarga]

Okay -- I'm quite new to Clojure so I might have misunderstood some stuff. If so, please tell me what's wrong and I'll try to fix it properly. I'll test 'my' version with strokes and see if everything works.

[dribnet]

Thanks, this seemed to work well. I did revert the test.cljs and fixed a typo there, and tests are now passing again. For reference, to run tests you compile and then open public/mrhyde-test.html in a browser. You should see something like this:

This shows that all 16 tests are working in two compilation modes (optimization whitespace and simple), but that in advanced optimization mode javascript cannot access clojure maps as js objects - which has always been the case because of symbol renaming. Let me know if you have any questions.

[matevarga]

Cool, thanks for merging. Do you tend to look at this lib once in a while, or is it kind of abandoned at the moment?

[kvey]

The version in clojars does not appear to include this update.

[dribnet]

Oops - sorry I missed these older messages. @matevarga - yes it's kind of abandoned, but hopefully interesting as a proof of concept if someone else is thinking of trying this approach. @kvey - my apologies about forgetting to deploy this change - I've now deployed this as [net.drib/mrhyde "0.5.4-SNAPSHOT"] and updated the README.

[arichiardi]

Is there any interest in upgrading this? I have quickly tried and the only failure with the new compiler has been array functions:

plus a warnings like:

WARNING: /home/arichiardi/git/mrhyde/target/cljsbuild-compiler-3/mrhyde/typepatcher.js:1060: WARNING - incomplete alias created for namespace cljs.core
var orig_fn = (cljs.core[s]);
               ^