Fix the tests and make SQLAlchemy 1.2.8 compatible#219
Merged
Conversation
I went to look if `fetchall()` downloads th entire result in memory and found that it was coded in a very low-level C style, while Python has a perfectly good idiomatic approach for such things. So I thought I'd submit a fix :-) Take it or leave it, I won't insist. P.S. I'm editing this from GitHub UI, so haven't run any tests. And although I'm fairly sure it should work as is, consider it formally as a demonstration :-)
Hello. I might be removing this prematurely, but `pip search thrift_sasl` now shows 0.3.0. Can this comment be removed? Also, I filled out the Dropbox Contributor License.
The methods allow us to use connections and cursors with `with`s statements.
The reason behind this is that non-integer sizes or None (or 0) do not make sense. Especially with None, which might be a common pattern, this should be prevented as it raises (cryptic) errors on the Thrift size.
Add decimal/timestamp conversion
Add script to generate new TCLIService files
Use a setter for arraysize
Add __enter__, __exit__ methods
Removing unreleased thrift_sasl comment
(More) idiomatic code for `fetchmany`, `fetchall`
6 tasks
|
Thanks for the great work! It looks like it's just failing on a few linter checks in generate.py. Mind fixing those? |
Contributor
Author
|
Thanks @gsilk for taking the time. I've just fixed the Flake8 violations. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 95.43% 93.92% -1.51%
==========================================
Files 14 14
Lines 1423 1482 +59
Branches 147 157 +10
==========================================
+ Hits 1358 1392 +34
- Misses 43 64 +21
- Partials 22 26 +4
Continue to review full report at Codecov.
|
Contributor
Author
|
Nice and green 😍 |
|
Thanks for the great work on this, I'll cut a 0.6.0 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dropbox,
Together with @gglanzai we've been working on getting PyHive compatible with SQLAlchemy 1.2.8 and make sure that the tests are running. Would it be possible to merge this and create a new release? We're wainting on this for Apache Airflow in apache/airflow#3432
Cheers, Fokko