Fix missing optional arguments to win over values#155
Open
svoop wants to merge 2 commits into
Open
Conversation
Contributor
|
As for spec, I was able to reproduce the bug (on main) like this: 6822f94 Otherwise, it looks like a great fix to me! |
Author
|
@katafrakt Sorry, dropped the ball here:
Not sure what you mean by that, shall I just add your tests to this PR? |
6ed5c5e to
60881d5
Compare
Contributor
|
@svoop I forgot about this PR, apologies. I pushed the test now to your branch (it needed some additional tweaking). I think we are good to go now with this? |
katafrakt
approved these changes
May 20, 2026
Contributor
|
Let's add a changelog entry though, before merging. |
Author
|
@katafrakt Thanks a bunch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #126 (comment)
Optional arguments (either implic or with explicit
required: false) should be accepted when missing even if avalueslist does not includenilas a value – at least as per the principle of least surprise.Not sure how best to spec this, hope it's okay to having added a vacuum subcommand to the db example.
/cc @gustavothecoder