fix/ios 15 bar appearance#20
Merged
Merged
Conversation
bishalfan
commented
Dec 30, 2021
bishalfan
commented
- Fix iOS 15 bars appearance (Fix iOS 15 bars appearance wix/react-native-navigation#7270)
- fix(BottomTabAppearancePresenter.h): bottom bar color not applying issue solved with cherry-pick
Following wix#7266 and especially [my comment there](wix#7266 (comment)), I'm opening this PR to provide a quick fix to people experiencing issues when building RNN using Xcode 13. This should be considered a fix PR rather than a feature PR, as what it's doing is basically duplicating the already set `standardAppearance` to a `scrollEdgeAppearance`. What this means is that the bars will have the same visual aspect whether they're displayed alongside the edge of a scroll view. In a future, more elaborate PR, we could imagine a way to be able to provide `scrollEdgeAppearance` values from JS for more control over the native bars. Fixes wix#7266 Fixes wix#7268 Co-authored-by: Yogev Ben David <yogev132@gmail.com>
…sue solved with cherry-pick
Author
|
No need of this pull request, latest master of wiz has this |
krishna-kb
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.