Sid translation#97
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #97 +/- ##
==================================
+ Coverage 81% 81% +<1%
==================================
Files 5 5
Lines 426 431 +5
==================================
+ Hits 347 353 +6
+ Misses 79 78 -1 |
Member
|
Review status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @jcwalker) DSCResources/SecurityPolicyResourceHelper/SecurityPolicyResourceHelper.psm1, line 402 at r1 (raw file):
Might want to make the data type the same for both string parameters in this function Comments from Reviewable |
johlju
added
needs review
Member
|
@jcwalker Can you write 'done' on the review comment so that @regedit32 can sign off (resolve his comment) on this? Reviewed 2 of 4 files at r1, 2 of 2 files at r2. Comments from Reviewable |
johlju
added
waiting for author response
Member
|
Review status: Comments from Reviewable |
complete! all files reviewed, all discussions resolved
johlju
removed
the
waiting for author response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional error handling to ConvertTo-Sid helper function
This change is